WEB-6573: Matches slide generator to carolus #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for modular content
| @@ -113,7 +113,7 @@ | |||
| ========================================================================== */ | |||
|
|
|||
| /* Title slide is a bigger size than video to go to a video file. So we need to scale all the sizes up */ | |||
| /* 2022 Oct sizing for carolus is height: 602px, width: 1072px.*/ | |||
| /* 2022 Oct sizing for carolus is height: 588px, width: 1036px.*/ | |||
There was a problem hiding this comment.
The height for video is not changed for module.
As I am not aware of exactly what goes in this, does main container width play a role in deciding what width and height should be?
KapilSachdev
approved these changes
Oct 16, 2023
|
It hasn't changed, but it has changed since this file was updated (i.e I think Luke went and did some changes, which meant that it has never matched...or that I took it from Figma, and the stuff on site was never that..) It's just a reference point, because this is a static image. I used it to figure out the break-points. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I have no idea how to test this, so probably will need to check on staging)