Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improved testing #96

Merged
merged 61 commits into from
Sep 10, 2024
Merged

chore: improved testing #96

merged 61 commits into from
Sep 10, 2024

Conversation

turtleDev
Copy link
Contributor

@turtleDev turtleDev commented Sep 7, 2024

Improved Test Coverage

This PR enhances test coverage across critical packages, achieving over 80% coverage. Key improvements include adding tests for edge cases and refactoring for better testability

Key Changes:

  1. Increased Test Coverage:

    • Updated coverage in key packages
    • Added tests for log publishers and edge cases in kinesis and pubsub.
  2. Refactoring & Bug Fixes:

    • Updated worker shutdown logic to close channels and ensure graceful exit.
    • Exposed metrics instruments for better test integration.
  3. Service Package Enhancements:

    • Enhanced gRPC and REST tests for error handling and acknowledgment types.
    • Renamed configs (AsynchronousAckAsync, SynchronousAckSync).
  4. CI Enhancements:

    • Enabled integration test coverage collection and merging with unit tests.
    • Fixed CI issues related to coverage reports and test output inconsistencies.
    • Generated coverage is not attached to each workflow run as an artefact.

@coveralls
Copy link

coveralls commented Sep 7, 2024

Pull Request Test Coverage Report for Build 10772558047

Details

  • 97 of 116 (83.62%) changed or added relevant lines in 18 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+38.8%) to 81.295%

Changes Missing Coverage Covered Lines Changed/Added Lines %
services/rest/websocket/handler.go 1 2 50.0%
app/server.go 9 11 81.82%
publisher/log/log.go 4 6 66.67%
config/errors.go 5 8 62.5%
metrics/mock.go 24 35 68.57%
Files with Coverage Reduction New Missed Lines %
config/errors.go 1 86.0%
Totals Coverage Status
Change from base Build 10601185135: 38.8%
Covered Lines: 1908
Relevant Lines: 2347

💛 - Coveralls

@ravisuhag ravisuhag changed the title Improved testing chore: improved testing Sep 10, 2024
@ravisuhag ravisuhag merged commit 5478dc3 into main Sep 10, 2024
8 checks passed
@ravisuhag ravisuhag deleted the improved-testing branch September 10, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants