Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: setup pipeline #1

Merged
merged 5 commits into from
Apr 13, 2021
Merged

build: setup pipeline #1

merged 5 commits into from
Apr 13, 2021

Conversation

NNcrawler
Copy link
Member

No description provided.

@NNcrawler NNcrawler force-pushed the setup-actions branch 8 times, most recently from dd48e1a to e2a0dd6 Compare April 11, 2021 09:02
@NNcrawler
Copy link
Member Author

An intermittent issue on unit test fails during the release that points to the branch. Couldn't figure out the root cause. Test and build run fine on the branch, docker image is also generated properly on docker hub. Tested using integration test point to docker run.

chakravarthyvp
chakravarthyvp reviewed Apr 12, 2021
View reviewed changes
.github/workflows/build.yaml Show resolved Hide resolved
.github/workflows/build.yaml Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
riteeksrivastav
riteeksrivastav reviewed Apr 12, 2021
View reviewed changes
logger/logger.go Outdated Show resolved Hide resolved
riteeksrivastav
riteeksrivastav reviewed Apr 13, 2021
View reviewed changes
logger/logger.go Outdated Show resolved Hide resolved
@NNcrawler @riteeksrivastav
fix: parse level on logger
e184f6e 
Co-authored-by: Riteek Srivastav <[email protected]>
@NNcrawler NNcrawler merged commit 0e16dd5 into main Apr 13, 2021
@ravisuhag ravisuhag deleted the setup-actions branch April 13, 2021 17:40
NNcrawler added a commit that referenced this pull request May 26, 2021
@NNcrawler
Merge pull request #1 from odpf/setup-actions
b6cea72 
build: setup pipeline
turtleDev added a commit that referenced this pull request Sep 5, 2024
@turtleDev
ci: prospective fix for coverdata #1
84fabf3
ravisuhag pushed a commit that referenced this pull request Sep 10, 2024
@turtleDev
chore: improved testing (#96)
5478dc3 
* publisher: log: add tests

* worker: test for ack function

* worker: tests: remove unused mocks

* worker: add tests for error cases

* worker: test: use constructor for tests

* app: worker: fix flush always timing out

* app: move kafka specific log messages to kafka publisher package

* wip: worker metrics test

* worker: add tests against instrumented metrics

* worker: rename timeSource to Clock

* chore: remove client example

* worker: use idiomatic null device for tests

* config: add tests for validation errors

* config: add test for valid configuration

* config: add tests for internal prepare()

* config: add tests for Walk()

* config: kafka: add tests for ToConfigMap()

* config: kafka: add more tests for config map serializer

* config: add tests for internal helper functions

* refactor: extract Clock to a stand alone package

* collector: add tests for TimePushed mutation

* serialization: add tests for SerialiseProto

* deserialization: add tests for DeserializeFunc

* worker: add test for flush time out

* config: refactor ack value names

* tests: integration e2e tests results in coverage data

* ci: test: fix coverage merge failing

* ci: prospective fix for coverdata #1

* ci: prospective fix for coverdata #2

* ci: prospective fix for coverdata #3

* ci: upload test coverage as artifact

* ci: refactor Docker build for release and testing

* services: grpc: add tests for synchronous event handling

* services: grpc: add tests to cover metric instrumentation

* services: rest: remove deadcode

For an incoming request, req.Body is never nil
https://pkg.go.dev/net/http#Request

* services: rest: add tests for error reading request body

* services: rest: add tests for malformed request body

* services: rest: refactor ack handling

* services: rest: add tests for different error paths

* ci: cache image pulls to speed up tests

* ci: fix docker image caching

* ci: ignore proto package during tests

* ci: remove docker image caching

* Revert "ci: ignore proto package during tests"

This reverts commit 75d0807.

* Revert "Revert "ci: ignore proto package during tests""

This reverts commit 1038f46.

* Revert "Revert "Revert "ci: ignore proto package during tests"""

This reverts commit a39cad6.

* publisher: log: move test event to root proto package

* ci: blacklist proto package during tests

* hack: publisher: log: use single spaced fields

* Revert "publisher: log: move test event to root proto package"

This reverts commit 7f837bf.

* Revert "ci: blacklist proto package during tests"

This reverts commit 0856073.

* Revert "hack: publisher: log: use single spaced fields"

This reverts commit 5ffb846.

* Revert "Revert "hack: publisher: log: use single spaced fields""

This reverts commit 67797d9.

* ci: ignore proto folders when computing coverage

* hack: publisher: log: use double spaced fields

* ci: fix coverage data merge

* ci: fix cover merge resulting in empty coverage file

* publish: kinesis: add tests for stream's existence check

* misc: improve test case description

* publisher: kinesis: add tests for hitting rate limits and quotas

* publisher: kinesis: refactor tests
ravisuhag pushed a commit that referenced this pull request Sep 12, 2024
@turtleDev
chore: reorganise Package Structure (#97)
a94d6f2 
* publisher: log: add tests

* worker: test for ack function

* worker: tests: remove unused mocks

* worker: add tests for error cases

* worker: test: use constructor for tests

* app: worker: fix flush always timing out

* app: move kafka specific log messages to kafka publisher package

* wip: worker metrics test

* worker: add tests against instrumented metrics

* worker: rename timeSource to Clock

* chore: remove client example

* worker: use idiomatic null device for tests

* config: add tests for validation errors

* config: add test for valid configuration

* config: add tests for internal prepare()

* config: add tests for Walk()

* config: kafka: add tests for ToConfigMap()

* config: kafka: add more tests for config map serializer

* config: add tests for internal helper functions

* refactor: extract Clock to a stand alone package

* collector: add tests for TimePushed mutation

* serialization: add tests for SerialiseProto

* deserialization: add tests for DeserializeFunc

* worker: add test for flush time out

* config: refactor ack value names

* tests: integration e2e tests results in coverage data

* ci: test: fix coverage merge failing

* ci: prospective fix for coverdata #1

* ci: prospective fix for coverdata #2

* ci: prospective fix for coverdata #3

* ci: upload test coverage as artifact

* ci: refactor Docker build for release and testing

* services: grpc: add tests for synchronous event handling

* services: grpc: add tests to cover metric instrumentation

* services: rest: remove deadcode

For an incoming request, req.Body is never nil
https://pkg.go.dev/net/http#Request

* services: rest: add tests for error reading request body

* services: rest: add tests for malformed request body

* services: rest: refactor ack handling

* services: rest: add tests for different error paths

* ci: cache image pulls to speed up tests

* ci: fix docker image caching

* ci: ignore proto package during tests

* ci: remove docker image caching

* Revert "ci: ignore proto package during tests"

This reverts commit 75d0807.

* Revert "Revert "ci: ignore proto package during tests""

This reverts commit 1038f46.

* Revert "Revert "Revert "ci: ignore proto package during tests"""

This reverts commit a39cad6.

* publisher: log: move test event to root proto package

* ci: blacklist proto package during tests

* hack: publisher: log: use single spaced fields

* Revert "publisher: log: move test event to root proto package"

This reverts commit 7f837bf.

* Revert "ci: blacklist proto package during tests"

This reverts commit 0856073.

* Revert "hack: publisher: log: use single spaced fields"

This reverts commit 5ffb846.

* Revert "Revert "hack: publisher: log: use single spaced fields""

This reverts commit 67797d9.

* ci: ignore proto folders when computing coverage

* hack: publisher: log: use double spaced fields

* ci: fix coverage data merge

* ci: fix cover merge resulting in empty coverage file

* publish: kinesis: add tests for stream's existence check

* misc: improve test case description

* publisher: kinesis: add tests for hitting rate limits and quotas

* publisher: kinesis: refactor tests

* hygiene: reorganise package structure

* refactor: merge serialization and deserialization pkg into serde

* docs: fix broken dashboard link

* serde: test: fix broken references

* refactor: integrate middleware package into server/rest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riteeksrivastav riteeksrivastav riteeksrivastav left review comments

@chakravarthyvp chakravarthyvp chakravarthyvp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NNcrawler @chakravarthyvp @riteeksrivastav