glfw: Sync our GLFW with upstream master #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will fix the Windows build error later |
|
Just note that |
|
@a3f any news on this PR? |
a3f
force-pushed
the
update-glfw
branch
2 times, most recently
from
dd18eef
to
1d6ba68
Compare
|
I've fixed the Windows build error, but Travis still fails because of the |
Move away from v1.12 as GLFW now requires >= 1.15.
glfw/glfw@5595fa3ae6 implements a proper fix for the macOS Mojave problem of OpenGL windows not being rendered until moved or manually updated. Pull in the current master and rebase the three patches we have on top: - two commits we have for reuse of the GLFW CMake build system for Wayland It hasn't yet to be acknowledged upstream. - one commit removing #include <windows.h> in glfw3native.h to avoid duplicate declarations. Fixes raysan5#655 and raysan5#665.
…S Mojave" This reverts commit 1fe6d9f. Because upstream GLFW now contains a fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
glfw/glfw@5595fa3 implements a proper fix for the macOS Mojave
problem of OpenGL windows not being rendered until moved or manually
updated.
Pull in the current master and rebase the two commits we have for reuse
of the GLFW CMake build system for Wayland on top. It hasn't been merged
(or acknowledged..) upstream yet.
Fixes #655 and #665.