[rtextures/rlgl] Load mipmaps for cubemaps #4429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not-Nik
force-pushed
the
cubemap_mipmaps
branch
from
6d20ec7
to
5a66053
Compare
|
@Not-Nik Thanks for the improvement! |
raysan5
added a commit
that referenced
this pull request
Oct 26, 2024
|
@Not-Nik I'm afraid this PR breaks |
raysan5
added a commit
that referenced
this pull request
Oct 26, 2024
|
I just put a quick fix to avoid the crash in the |
|
The fix should comment out both mipmap generations, other wise OpenGL will try to read mipmaps that aren't properly generated |
|
I found the bug, I'll create a fixup PR in 20 minutes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load all mipmaps for cubemaps to the GPU and enable the proper filters for them. This is especially important for image based lighting (IBL), where for different roughness levels, different pre-filtered environment maps are stored in mipmaps. Calculating these filters is rather expensive, so it is often done offline and the pre-filtered cubemaps are shipped with the game.
The implementation did require some reworking; notably
rlLoadTextureCubemapgains a newmipmapCountparameter, andImageMipmapsno longer regenerates already existing mipmaps.I structured the PR to be able to just be rebased onto master if you want all the different changes to reflect in the tree.