Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[models] Load bone names from IQM file if available #2882

Merged
merged 2 commits into from
Jan 23, 2023

Conversation

PencilAmazing
Copy link
Contributor

@PencilAmazing PencilAmazing commented Jan 22, 2023

Simply checks if joints were loaded in with animations file, and copies string data to name.
One issue is that maybe we should be using strcpy_s instead of raw memcpy?
Fixes #2863

@PencilAmazing PencilAmazing changed the title [Models] Load bone names from IQM file if available [models] Load bone names from IQM file if available Jan 22, 2023
src/rmodels.c Show resolved Hide resolved
src/rmodels.c Outdated Show resolved Hide resolved
@raysan5
Copy link
Owner

raysan5 commented Jan 23, 2023

@PencilAmazing Thanks for the improvement, just added some reviews.

@raysan5 raysan5 merged commit 542ef89 into raysan5:master Jan 23, 2023
@raysan5
Copy link
Owner

raysan5 commented Jan 23, 2023

@PencilAmazing Thank you very much for the review! :)

@PencilAmazing
Copy link
Contributor Author

PencilAmazing commented Jan 23, 2023

@raysan5 Thanks for the quick merge!

@PencilAmazing PencilAmazing deleted the #2863 branch January 24, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[rmodel] IQM Animations do not load joint names
2 participants