Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rmodel] IQM Animations do not load joint names #2863

Closed
PencilAmazing opened this issue Jan 16, 2023 · 3 comments · Fixed by #2882
Closed

[rmodel] IQM Animations do not load joint names #2863

PencilAmazing opened this issue Jan 16, 2023 · 3 comments · Fixed by #2882
Labels
good first issue Good first issue to help with

Comments

@PencilAmazing
Copy link
Contributor

Issue description

I'm trying to search for bone transforms using bone name, but LoadModelAnimationsIQM discards joint names for some reason and just writes "ANIMJOINTNAME" to BoneInfo.name

Code Example

https://github.com/raysan5/raylib/blob/master/src/rmodels.c#L4504

@raysan5
Copy link
Owner

raysan5 commented Jan 20, 2023

@PencilAmazing Does IQM provide joint names data? In any case, BoneInfo.name is only 32 bytes, I tried to keep the object small. Afaik in most situations bone names are not that useful and they can be better accessed by index.

@PencilAmazing
Copy link
Contributor Author

PencilAmazing commented Jan 20, 2023

@raysan5 My use case was to load custom models and allow the user to specify a bone by name then attach a model to it's transform. I could force the user to memorize a magic index number for the model and hope the bone order never changes, but the inbuilt raylib structure field is simply being left unused for no real reason.
And yes, my IQM file does have joint names data and already is being loaded for skeletal models. I would imagine that 32 bytes is enough for most bone names.

@raysan5
Copy link
Owner

raysan5 commented Jan 20, 2023

@PencilAmazing ok, could you send a PR to fill name data?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good first issue to help with
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants