Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streaming executor fixes #4 #32882

Merged
merged 45 commits into from
Mar 1, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
edc51bd
Fix read_tfrecords_benchmark nightly test
jianoaix Dec 8, 2022
61f4d6d
Merge branch 'master' of https://github.com/ray-project/ray
jianoaix Dec 14, 2022
a33a943
Merge branch 'master' of https://github.com/ray-project/ray
jianoaix Dec 16, 2022
36ebe52
Merge branch 'master' of https://github.com/ray-project/ray
jianoaix Dec 16, 2022
ce6763e
Merge branch 'master' of https://github.com/ray-project/ray
jianoaix Dec 19, 2022
0e2c29e
Merge branch 'master' of https://github.com/ray-project/ray
jianoaix Dec 21, 2022
f2b6ed0
Merge branch 'master' of https://github.com/ray-project/ray
jianoaix Dec 22, 2022
bb6c5c4
Merge branch 'master' of https://github.com/ray-project/ray
jianoaix Jan 4, 2023
540fe79
Merge branch 'master' of https://github.com/ray-project/ray
jianoaix Jan 10, 2023
edad7d0
Merge branch 'master' of https://github.com/ray-project/ray
jianoaix Jan 10, 2023
60cc079
Merge branch 'master' of https://github.com/ray-project/ray
jianoaix Jan 11, 2023
a3d3980
Merge branch 'master' of https://github.com/ray-project/ray
jianoaix Jan 12, 2023
001579c
Merge branch 'master' of https://github.com/ray-project/ray
jianoaix Jan 17, 2023
8aeed6c
Merge branch 'master' of https://github.com/ray-project/ray
jianoaix Jan 18, 2023
7a9a49b
Merge branch 'master' of https://github.com/ray-project/ray
jianoaix Jan 19, 2023
ef97167
Merge branch 'master' of https://github.com/ray-project/ray
jianoaix Jan 20, 2023
6f0563c
Merge branch 'master' of https://github.com/ray-project/ray
jianoaix Jan 21, 2023
bcec4d6
Merge branch 'master' of https://github.com/ray-project/ray
jianoaix Jan 24, 2023
ddef4e5
Merge branch 'master' of https://github.com/ray-project/ray
jianoaix Jan 25, 2023
fc9a175
Merge branch 'master' of https://github.com/ray-project/ray
jianoaix Jan 25, 2023
f0e90b7
Merge branch 'master' of https://github.com/ray-project/ray
jianoaix Jan 26, 2023
999d1de
Merge branch 'master' of https://github.com/ray-project/ray
jianoaix Jan 26, 2023
d8159e3
Merge branch 'master' of https://github.com/ray-project/ray
jianoaix Jan 30, 2023
d81cd02
Merge branch 'master' of https://github.com/ray-project/ray
jianoaix Jan 31, 2023
bc831bb
Merge branch 'master' of https://github.com/ray-project/ray
jianoaix Jan 31, 2023
c444395
Merge branch 'master' of https://github.com/ray-project/ray
jianoaix Feb 2, 2023
642da6f
Merge branch 'master' of https://github.com/ray-project/ray
jianoaix Feb 3, 2023
f713f2f
Merge branch 'master' of https://github.com/ray-project/ray
jianoaix Feb 6, 2023
d416a73
Merge branch 'master' of https://github.com/ray-project/ray
jianoaix Feb 9, 2023
da5acee
Merge branch 'master' of https://github.com/ray-project/ray
jianoaix Feb 10, 2023
ab64cb6
Merge branch 'master' of https://github.com/ray-project/ray
jianoaix Feb 10, 2023
7a5d5e3
Merge branch 'master' of https://github.com/ray-project/ray
jianoaix Feb 11, 2023
47010ca
Merge branch 'master' of https://github.com/ray-project/ray
jianoaix Feb 13, 2023
b9fcb5f
Merge branch 'master' of https://github.com/ray-project/ray
jianoaix Feb 13, 2023
9cb959d
Merge branch 'master' of https://github.com/ray-project/ray
jianoaix Feb 14, 2023
3f26b7c
Merge branch 'master' of https://github.com/ray-project/ray
jianoaix Feb 17, 2023
d841b33
Merge branch 'master' of https://github.com/ray-project/ray
jianoaix Feb 21, 2023
0ce805c
Merge branch 'master' of https://github.com/ray-project/ray
jianoaix Feb 23, 2023
0258409
Merge branch 'master' of https://github.com/jianoaix/ray
jianoaix Feb 28, 2023
846cc65
Streaming executor fixes #4
jianoaix Feb 28, 2023
7edecbd
force bulk execution
jianoaix Feb 28, 2023
e4e8d38
fix zip
jianoaix Feb 28, 2023
367354d
fix
jianoaix Feb 28, 2023
f6af0a9
Merge branch 'master' of https://github.com/ray-project/ray into stre…
jianoaix Feb 28, 2023
f7069c9
Merge branch 'master' of https://github.com/ray-project/ray into stre…
jianoaix Mar 1, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions python/ray/data/tests/test_bulk_executor.py
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ def test_actor_strategy(ray_start_10_cpus_shared):

def test_new_execution_backend_invocation(ray_start_10_cpus_shared):
DatasetContext.get_current().new_execution_backend = True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is called test_bulk_executor so shall we just force bulk execution mode instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

DatasetContext.get_current().use_streaming_executor = False
# Read-only: will use legacy executor for now.
ds = ray.data.range(10)
assert ds.take_all() == list(range(10))
Expand Down
7 changes: 4 additions & 3 deletions python/ray/data/tests/test_dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -382,12 +382,13 @@ def test_zip_different_num_blocks_split_smallest(
[{str(i): i for i in range(num_cols1, num_cols1 + num_cols2)}] * n,
parallelism=num_blocks2,
)
ds = ds1.zip(ds2)
ds = ds1.zip(ds2).fully_executed()
num_blocks = ds._plan._snapshot_blocks.executed_num_blocks()
assert ds.take() == [{str(i): i for i in range(num_cols1 + num_cols2)}] * n
if should_invert:
assert ds.num_blocks() == num_blocks2
assert num_blocks == num_blocks2
else:
assert ds.num_blocks() == num_blocks1
assert num_blocks == num_blocks1
Comment on lines +385 to +391
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious as #32860 is merged, would the change here is still needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested that PR with streaming enabled for this test? Also note this is to handle issue introduced in #32132.



def test_zip_pandas(ray_start_regular_shared):
Expand Down