Streaming executor fixes #4 #32882
Merged
Streaming executor fixes #4 #32882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jianoaix <[email protected]>
ericl
reviewed
Feb 28, 2023
| @@ -127,7 +127,11 @@ def test_new_execution_backend_invocation(ray_start_10_cpus_shared): | |||
| DatasetContext.get_current().new_execution_backend = True | |||
There was a problem hiding this comment.
This test is called test_bulk_executor so shall we just force bulk execution mode instead?
ericl
added
the
@author-action-required
|
Failing tests seem not related. |
jianoaix
removed
the
@author-action-required
c21
reviewed
Feb 28, 2023
Comment on lines
+387
to
+393
| ds = ds1.zip(ds2).fully_executed() | ||
| num_blocks = ds._plan._snapshot_blocks.executed_num_blocks() | ||
| assert ds.take() == [{str(i): i for i in range(num_cols1 + num_cols2)}] * n | ||
| if should_invert: | ||
| assert ds.num_blocks() == num_blocks2 | ||
| assert num_blocks == num_blocks2 | ||
| else: | ||
| assert ds.num_blocks() == num_blocks1 | ||
| assert num_blocks == num_blocks1 |
ericl
approved these changes
Feb 28, 2023
ericl
added
the
@author-action-required
|
Test failures |
jianoaix
added
tests-ok
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
Mar 21, 2023
Signed-off-by: Jack He <[email protected]>
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
Signed-off-by: Edward Oakes <[email protected]>
peytondmurray
pushed a commit
to peytondmurray/ray
that referenced
this pull request
Mar 22, 2023
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
Signed-off-by: Jack He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The streaming doesn't preserve order by default, so the results comparison will need to use set instead of list.
#32132
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.