[serve] Integrate and Document Bring-Your-Own Gradio Applications (#2… #27560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y-project#26403) Integration between Ray Serve and Gradio. Users of Gradio can wrap their Gradio app in a Serve deployment by using `GradioIngress`, and scale it up through more replicas or more CPU/GPU resources. Signed-off-by: Cindy Zhang <[email protected]>
zcin
requested review from
edoakes,
simon-mo,
jiaodong,
shrekris-anyscale,
sihanwang41,
richardliaw and
ericl
as code owners
Signed-off-by: Cindy Zhang <[email protected]>
zcin
commented
Aug 5, 2022
|
|
||
| import starlette | ||
|
|
||
| try: |
There was a problem hiding this comment.
Super sorry, I had written a "hacky" way of telling the user when they don't have gradio installed, and forgot to change it before this got merged into master. The "hacky" way has correct functionality but ugly code. I've pushed a new commit fixing this for now, let me know if this should be reverted for another approach!
There was a problem hiding this comment.
I think this is ok to merge
edoakes
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…6403)
Integration between Ray Serve and Gradio. Users of Gradio can wrap their Gradio app in a Serve deployment by using
GradioIngress, and scale it up through more replicas or more CPU/GPU resources.Signed-off-by: Cindy Zhang [email protected]
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.