[serve] Integrate and Document Bring-Your-Own Gradio Applications #26403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcin
added
serve
zcin
requested review from
edoakes,
simon-mo,
jiaodong,
shrekris-anyscale,
richardliaw and
ericl
as code owners
edoakes
reviewed
Jul 14, 2022
python/ray/serve/gradio.py
Outdated
|
|
||
| class GradioIngress: | ||
| def __init__(self, io: gr.Blocks): | ||
| self.app = gr.routes.App.create_app(io) |
There was a problem hiding this comment.
Is this a public API that's guaranteed by gradio to remain stable?
There was a problem hiding this comment.
Not that I know of. Should we sync with Gradio team on this?
There was a problem hiding this comment.
Yes, definitely. We need to make sure any APIs we use are public & stable otherwise our integration could break at any point without warning.
There was a problem hiding this comment.
Abubakar confirmed that this API will remain stable, and they will add tests around gr.routes.App.create_app() to make sure the API signature doesn't change!
Comment on lines
247
to
249
| def fanout(self, text): | ||
| [result1, result2] = ray.get([self._d1.remote(text), self._d2.remote(text)]) | ||
| return f"{result1}\n------------\n{result2}" |
There was a problem hiding this comment.
nit: use async def as best practice :)
There was a problem hiding this comment.
Unfortunately Gradio doesn't support async functions in gr.Interface yet :(
shrekris-anyscale
requested changes
Jul 18, 2022
simon-mo
changed the title
simon-mo
reviewed
Jul 22, 2022
| - ./ci/ci.sh build | ||
| - bazel test --config=ci $(./ci/run/bazel_export_options) | ||
| --test_tag_filters=team:serve | ||
| python/ray/serve/test_gradio |
There was a problem hiding this comment.
you should also filter out this test from regular test suites both in windows (ci.sh) and here.
doc/source/serve/tutorials/index.md
Outdated
| @@ -16,6 +16,7 @@ batch | |||
| web-server-integration | |||
| rllib | |||
| gradio | |||
There was a problem hiding this comment.
Got it, I'll remove the actual file as well.
Signed-off-by: Cindy Zhang <[email protected]>
shrekris-anyscale
approved these changes
Aug 2, 2022
Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: Cindy Zhang <[email protected]>
edoakes
approved these changes
Aug 5, 2022
zcin
added a commit
to zcin/ray
that referenced
this pull request
Aug 5, 2022
…y-project#26403) Integration between Ray Serve and Gradio. Users of Gradio can wrap their Gradio app in a Serve deployment by using `GradioIngress`, and scale it up through more replicas or more CPU/GPU resources. Signed-off-by: Cindy Zhang <[email protected]>
zcin
added a commit
that referenced
this pull request
Aug 8, 2022
…Applications (#26403)" (#27587)" This reverts commit 64c550a. Signed-off-by: Cindy Zhang <[email protected]>
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
…y-project#26403) Integration between Ray Serve and Gradio. Users of Gradio can wrap their Gradio app in a Serve deployment by using `GradioIngress`, and scale it up through more replicas or more CPU/GPU resources. Signed-off-by: Stefan van der Kleij <[email protected]>
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
…ions (ray-project#26403)" (ray-project#27587) This reverts commit 8a9d994. Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Integration between Ray Serve and Gradio. Users of Gradio can wrap their Gradio app in a Serve deployment by using
GradioIngress, and scale it up through more replicas or more CPU/GPU resources.Related issue number
Checks
scripts/format.shto lint the changes in this PR.