Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix vcfiled cross-compile install #525

Merged
merged 1 commit into from
Jan 15, 2019

Conversation

jwinarske
Copy link
Contributor

Cross compile install fails with vcfiled, as it is attempting to write /etc/init.d. This should be ${CMAKE_INSTALL_PREFIX}/etc/init.d.

@popcornmix popcornmix merged commit e5803f2 into raspberrypi:master Jan 15, 2019
@popcornmix
Copy link
Contributor

Possibly dropping vcfiled completely would be good (it's not used), but your change looks like an improvement.

@6by9
Copy link
Contributor

6by9 commented Jan 15, 2019

vcfiled is not used (it allows the VPU to access the host filing system, but the VPU side isn't built), so worth dropping.

Purge totally from the repo, or just drop from the build?

@jwinarske jwinarske deleted the vcfiled_install branch January 15, 2019 16:40
@popcornmix
Copy link
Contributor

@6by9 no objections to deletion (it won't be coming back).
Technically if it's not built from vc4 tree it will result in deletion from userland tree (only built source is included).

@6by9
Copy link
Contributor

6by9 commented Jan 15, 2019

Technically if it's not built from vc4 tree it will result in deletion from userland tree (only built source is included).

If I've understood you correctly then it should automagically purge itself once you've picked this change to vc4 and rerun your scripts? In which case I won't create userland PRs to remove it.

@popcornmix
Copy link
Contributor

If I've understood you correctly then it should automagically purge itself once you've picked this change to vc4 and rerun your scripts?

This PR doesn't stop vcfiled from being built though.

@6by9
Copy link
Contributor

6by9 commented Jan 15, 2019

This PR doesn't stop vcfiled from being built though.

:-) Nor it does.
I'll create a vc4 PR to drop it from the build, so hopefully that will ripple through easily.

popcornmix added a commit to raspberrypi/firmware that referenced this pull request Jan 22, 2019
kernel: overlays: Add ssd1306 overlay for OLED display
See: #1098

kernel: overlays: mcp23017: Support the MCP23008
See: raspberrypi/linux#2818

kernel: overlays: Add mcp342x overlay
See: raspberrypi/linux#2819

kernel: configs: Add CONFIG_USB_UAS=m
See: raspberrypi/linux#2813

firmware: interface: Drop vcfiled
See: raspberrypi/userland#525

firmware: Add reference counting to the local audio players
See: #547

firmware: arm_loader: Add reporting the firmware git hash via the mailbox
firmware: vcos: Add reporting of which variant was built
See: raspberrypi/linux#2806

firmware: Update vcdbg help
See: #594
popcornmix added a commit to Hexxeh/rpi-firmware that referenced this pull request Jan 22, 2019
kernel: overlays: Add ssd1306 overlay for OLED display
See: raspberrypi/firmware#1098

kernel: overlays: mcp23017: Support the MCP23008
See: raspberrypi/linux#2818

kernel: overlays: Add mcp342x overlay
See: raspberrypi/linux#2819

kernel: configs: Add CONFIG_USB_UAS=m
See: raspberrypi/linux#2813

firmware: interface: Drop vcfiled
See: raspberrypi/userland#525

firmware: Add reference counting to the local audio players
See: raspberrypi/firmware#547

firmware: arm_loader: Add reporting the firmware git hash via the mailbox
firmware: vcos: Add reporting of which variant was built
See: raspberrypi/linux#2806

firmware: Update vcdbg help
See: raspberrypi/firmware#594
5schatten pushed a commit to 5schatten/LibreELEC-RR that referenced this pull request Jan 25, 2019
mkreisl added a commit to xbianonpi/xbian-package-firmware that referenced this pull request Feb 4, 2019
- bootcode: Re-enable the pull down on SD CLK pin immediately.

- firmware: Rawcam: Fixup buffering issues on fast fps

- firmware: MMAL alignment changes, plus a couple of minor fixes

- firmware: MMAL/IL: Fix for reducing alignment patch
  See: https://www.raspberrypi.org/forums/viewtopic.php?f=43&t=62364

- firmware: Added a dpi_timings config item

- firmware: Add DPI Driver default settings

- firmware: HVS channel should come from the DISPLAY_INFO

- firmware: Add POE HAT support

- firmware: video_encode: Drop back to software conversion if stride is not mod32
  See: Hexxeh/rpi-firmware#182

- firmware: arm_dt: Break out GPIO save/restore from HAT code as needed for PoE

- firmware: rawcam: Fix double buffer return issue
  firmware: rawcam: Code cleanup

- firmware: host_apps: Fixup partially merged commit from userland
  See: #1027

- firmware: mmal: Add KEEP_PORT_FORMATS flag to mmal connection
  See: raspberrypi/userland#483

- firmware: RaspiStill: Apply gpsd info as EXIF tags
  See: raspberrypi/userland#286

- firmware: arm_dt: Work around an absent cache-line-size
  See: raspberrypi/linux#2643

- firmware: Camplus: annotate: Check lines_available >= lines_required
  See: raspberrypi/userland#485

- firmware: video_decode: Fix memory leak on passing in codec config multiple times

- firmware: mmal: Correct encoding 4CC for SBGGR16

- firmware: 2ndstage: Report IP address in ARP response in network order

- firmware: video_decode: Fix error in previous memory leak patch

- firmware: video_encode: Add ISP conversion support for RGBX32

- firmware: platform: Also report soft temperature limit in get_throttled bits

- firmware: IL isp: minor code cleanups
- firmware: image_encode: Support Video domain on input port

- firmware: video_encode: Use default values on invalid nStride or nSliceHeight
  See: #1051

- firmware: gpioman/FXL6408: Handle open failing sensibly
  See: #1053

- firmware: Delay backlight coming on
  See: #1052

- firmware: LCD driver close fixes

- firmware: jpeg/mjpeg: MJPEG doesn't insert JFIF APP0 header
  See: raspberrypi/userland#345

- firmware: Add IL HVS component

- firmware: mmal: Acquire zero copy buffers on being passed to the VPU

- firmware: video_render: Use per pixel alpha on RGBA and BGRA

- firmware: video_render: Add support for alpha options (MIX and PREMULT)

- firmware: Move to driver based backlight
  See: #1063

- bootcode: Extend TEST_UNIT_READY timeout to 20 seconds, some hard drives take a really long time
  See: #898

- firmware: video_render: Treat an empty buffer with ENDOFFRAME set as a flush

- firmware: dispmanx: Add option to ignore all layers lower than the current layer

- firmware: arm_dt: Accept "csi" as a special DT node that masks IRQs

- firmware: MMAL: Include OPAQUE in the list of supported encodings where appropriate
  See: https://www.raspberrypi.org/forums/viewtopic.php?f=67&t=226416

- firmware: video_render: asserting on the buffer being unlocked is invalid

- firmware: video_render: Further fix to a vcos_verify

- firmware: IL hvs: Fail component create if the HVS or TXP interrupts are masked

- firmware: Clean up masked interrupt handling - moves it to intctrl

- firmware: vcinclude: Clean up INTERRUPT_xxx defines to use one place

- firmware: vcfw: camera_subsystem: Stop cameras being detected if ARM has Unicam instance

- firmware: vc_image: Fix up vc_image_bits_per_pixel for YUYV variants and BGR888

- firmware: vc_image: Make the alternate path in yuv420 to rgb888 support bgr888

- firmware: vc_image: Add an rgb_stripe_swap_ext which takes pitches

- firmware: vc_image_convert: yuv420 to bgr888 failed on (width&31) != 0

- firmware: IL isp: Use gamma block to shift 10bpp YUV to the correct pipe depth

- firmware: video_encode: Always set the input port nBufferSize to match the image

- firmware: Camera/ISP: Allow option to disable demosaicing

- firmware: dispmanx: Also apply overscan_scale when clamping to screen
  See: https://forum.kodi.tv/showthread.php?tid=338052

- firmware: Added a mailbox function for setting gamma

- firmware: bootcode: Support parsing of gpio filters from config.txt
  See: #1076

- firmware: video_encode: Allow Inline Headers to be changed whilst active

- firmware: IL: Add XRGB8888 and XBGR8888, and support on video_render, isp, and hvs

- firmware: image_encode: Allow arbitrary buffer strides matching the appropriate multiples

- firmware: platform: Use 3aplus dt-blob section and bcm2710-rpi-3-a-plus.dtb

- firmware: Added ability to have an third transpose buffer
  See: #837

- firmware: isp: Correct the conversion tables changed in adding the gamma block
  See: #1084

- firmware: raspberrypi_full variant: Drop unused Camplus sw stages

- bootcode: Reset WiFi and BT devices before resetting the expander
  See: #1088

- bootcode: Fix Ethernet boot on a different subnet
  See: #1078

- firmware: interface: Drop vcfiled
  See: raspberrypi/userland#525

- firmware: Add reference counting to the local audio players
  See: #547

- firmware: arm_loader: Add reporting the firmware git hash via the mailbox

- firmware: vcos: Add reporting of which variant was built
  See: raspberrypi/linux#2806

- firmware: Update vcdbg help
  See: #594
m-honda added a commit to m-honda/raspberrypi-firmware that referenced this pull request Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants