raspberrypi firmware driver to log build variant and hash during probe. #2806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelwell
reviewed
Jan 11, 2019
6by9
force-pushed
the
rpi-4.19.y-clean
branch
from
4626bf0 to
e13bbb3
Compare
|
Sorry, introduced blank line errors there. Repushing in a mo. |
6by9
force-pushed
the
rpi-4.19.y-clean
branch
from
e13bbb3 to
9855e35
Compare
The driver already reported the firmware build date during probe. The mailbox calls have been extended to also report the variant 1 = standard start.elf 2 = start_x.elf (includes camera stack) 3 = start_db.elf (includes assert logging) 4 = start_cd.elf (cutdown version for smallest memory footprint). Log the variant during probe. Signed-off-by: Dave Stevenson <[email protected]>
|
Fixed those. Hopefully good to go now. |
|
I just noticed the & on the Other than that, LGTM. |
The firmware can now report the git hash from which it was built via the mailbox, so report it during probe. Signed-off-by: Dave Stevenson <[email protected]>
Happy to update. |
6by9
force-pushed
the
rpi-4.19.y-clean
branch
from
9855e35 to
c2118c5
Compare
|
Can we also get these sent upstream, they'll be universally useful for debug :) |
Upstreaming stuff isn't a hugely high priority for us, but it'll get added to the list. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Jan 22, 2019
kernel: overlays: Add ssd1306 overlay for OLED display See: #1098 kernel: overlays: mcp23017: Support the MCP23008 See: raspberrypi/linux#2818 kernel: overlays: Add mcp342x overlay See: raspberrypi/linux#2819 kernel: configs: Add CONFIG_USB_UAS=m See: raspberrypi/linux#2813 firmware: interface: Drop vcfiled See: raspberrypi/userland#525 firmware: Add reference counting to the local audio players See: #547 firmware: arm_loader: Add reporting the firmware git hash via the mailbox firmware: vcos: Add reporting of which variant was built See: raspberrypi/linux#2806 firmware: Update vcdbg help See: #594
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Jan 22, 2019
kernel: overlays: Add ssd1306 overlay for OLED display See: raspberrypi/firmware#1098 kernel: overlays: mcp23017: Support the MCP23008 See: raspberrypi/linux#2818 kernel: overlays: Add mcp342x overlay See: raspberrypi/linux#2819 kernel: configs: Add CONFIG_USB_UAS=m See: raspberrypi/linux#2813 firmware: interface: Drop vcfiled See: raspberrypi/userland#525 firmware: Add reference counting to the local audio players See: raspberrypi/firmware#547 firmware: arm_loader: Add reporting the firmware git hash via the mailbox firmware: vcos: Add reporting of which variant was built See: raspberrypi/linux#2806 firmware: Update vcdbg help See: raspberrypi/firmware#594
mkreisl
added a commit
to xbianonpi/xbian-package-firmware
that referenced
this pull request
Feb 4, 2019
- bootcode: Re-enable the pull down on SD CLK pin immediately. - firmware: Rawcam: Fixup buffering issues on fast fps - firmware: MMAL alignment changes, plus a couple of minor fixes - firmware: MMAL/IL: Fix for reducing alignment patch See: https://www.raspberrypi.org/forums/viewtopic.php?f=43&t=62364 - firmware: Added a dpi_timings config item - firmware: Add DPI Driver default settings - firmware: HVS channel should come from the DISPLAY_INFO - firmware: Add POE HAT support - firmware: video_encode: Drop back to software conversion if stride is not mod32 See: Hexxeh/rpi-firmware#182 - firmware: arm_dt: Break out GPIO save/restore from HAT code as needed for PoE - firmware: rawcam: Fix double buffer return issue firmware: rawcam: Code cleanup - firmware: host_apps: Fixup partially merged commit from userland See: #1027 - firmware: mmal: Add KEEP_PORT_FORMATS flag to mmal connection See: raspberrypi/userland#483 - firmware: RaspiStill: Apply gpsd info as EXIF tags See: raspberrypi/userland#286 - firmware: arm_dt: Work around an absent cache-line-size See: raspberrypi/linux#2643 - firmware: Camplus: annotate: Check lines_available >= lines_required See: raspberrypi/userland#485 - firmware: video_decode: Fix memory leak on passing in codec config multiple times - firmware: mmal: Correct encoding 4CC for SBGGR16 - firmware: 2ndstage: Report IP address in ARP response in network order - firmware: video_decode: Fix error in previous memory leak patch - firmware: video_encode: Add ISP conversion support for RGBX32 - firmware: platform: Also report soft temperature limit in get_throttled bits - firmware: IL isp: minor code cleanups - firmware: image_encode: Support Video domain on input port - firmware: video_encode: Use default values on invalid nStride or nSliceHeight See: #1051 - firmware: gpioman/FXL6408: Handle open failing sensibly See: #1053 - firmware: Delay backlight coming on See: #1052 - firmware: LCD driver close fixes - firmware: jpeg/mjpeg: MJPEG doesn't insert JFIF APP0 header See: raspberrypi/userland#345 - firmware: Add IL HVS component - firmware: mmal: Acquire zero copy buffers on being passed to the VPU - firmware: video_render: Use per pixel alpha on RGBA and BGRA - firmware: video_render: Add support for alpha options (MIX and PREMULT) - firmware: Move to driver based backlight See: #1063 - bootcode: Extend TEST_UNIT_READY timeout to 20 seconds, some hard drives take a really long time See: #898 - firmware: video_render: Treat an empty buffer with ENDOFFRAME set as a flush - firmware: dispmanx: Add option to ignore all layers lower than the current layer - firmware: arm_dt: Accept "csi" as a special DT node that masks IRQs - firmware: MMAL: Include OPAQUE in the list of supported encodings where appropriate See: https://www.raspberrypi.org/forums/viewtopic.php?f=67&t=226416 - firmware: video_render: asserting on the buffer being unlocked is invalid - firmware: video_render: Further fix to a vcos_verify - firmware: IL hvs: Fail component create if the HVS or TXP interrupts are masked - firmware: Clean up masked interrupt handling - moves it to intctrl - firmware: vcinclude: Clean up INTERRUPT_xxx defines to use one place - firmware: vcfw: camera_subsystem: Stop cameras being detected if ARM has Unicam instance - firmware: vc_image: Fix up vc_image_bits_per_pixel for YUYV variants and BGR888 - firmware: vc_image: Make the alternate path in yuv420 to rgb888 support bgr888 - firmware: vc_image: Add an rgb_stripe_swap_ext which takes pitches - firmware: vc_image_convert: yuv420 to bgr888 failed on (width&31) != 0 - firmware: IL isp: Use gamma block to shift 10bpp YUV to the correct pipe depth - firmware: video_encode: Always set the input port nBufferSize to match the image - firmware: Camera/ISP: Allow option to disable demosaicing - firmware: dispmanx: Also apply overscan_scale when clamping to screen See: https://forum.kodi.tv/showthread.php?tid=338052 - firmware: Added a mailbox function for setting gamma - firmware: bootcode: Support parsing of gpio filters from config.txt See: #1076 - firmware: video_encode: Allow Inline Headers to be changed whilst active - firmware: IL: Add XRGB8888 and XBGR8888, and support on video_render, isp, and hvs - firmware: image_encode: Allow arbitrary buffer strides matching the appropriate multiples - firmware: platform: Use 3aplus dt-blob section and bcm2710-rpi-3-a-plus.dtb - firmware: Added ability to have an third transpose buffer See: #837 - firmware: isp: Correct the conversion tables changed in adding the gamma block See: #1084 - firmware: raspberrypi_full variant: Drop unused Camplus sw stages - bootcode: Reset WiFi and BT devices before resetting the expander See: #1088 - bootcode: Fix Ethernet boot on a different subnet See: #1078 - firmware: interface: Drop vcfiled See: raspberrypi/userland#525 - firmware: Add reference counting to the local audio players See: #547 - firmware: arm_loader: Add reporting the firmware git hash via the mailbox - firmware: vcos: Add reporting of which variant was built See: raspberrypi/linux#2806 - firmware: Update vcdbg help See: #594
|
@6by9 Any plans to upstream this month? I only need to know. |
|
@lategoodbye Sorry, snowed under with other stuff at the moment, so very unlikely to be sorting patches to send this upstream. Assuming vc04_services hasn't moved too far, I will try to sort out my patches for the camera stack as those were pretty much sorted. |
|
No problem, i try to take care at least of the variant patch. vc04_services has been very quiet since beginning of the new year. So good luck. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires the associated firmware change to work, but will behave sensibly if it is absent.