Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dtoverlays: enable SPI CS active-high #6477

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

ikerexxe
Copy link
Contributor

The documentation isn't very clear explaining how to enable SPI CS active-high and it takes a long time to understand it. Adding a specific overlay as a simple example on how to invert this signal can help understand the solution.

Link: https://forums.raspberrypi.com/viewtopic.php?t=378222

@ikerexxe
Copy link
Contributor Author

CC'ing @martinezjavier

@popcornmix popcornmix force-pushed the rpi-6.12.y branch 2 times, most recently from 886c7da to 12856cc Compare November 18, 2024 14:25
@pelwell
Copy link
Contributor

pelwell commented Nov 18, 2024

You would be better off submitting your PR to rpi-6.6.y, from where we can forward port it. Otherwise you are in danger of having rpi-6.12.y rebased under your feet - which is what has just happened.

@ikerexxe ikerexxe changed the base branch from rpi-6.12.y to rpi-6.6.y November 18, 2024 15:28
@ikerexxe
Copy link
Contributor Author

You would be better off submitting your PR to rpi-6.6.y, from where we can forward port it. Otherwise you are in danger of having rpi-6.12.y rebased under your feet - which is what has just happened.

Done!

@pelwell
Copy link
Contributor

pelwell commented Nov 18, 2024

You'll need to fix these problems: https://github.com/raspberrypi/linux/actions/runs/11895664817/job/33146805156?pr=6477#step:4:559

The syntax error occurs because you aren't including <dt-bindings/gpio/gpio.h>, which you need for GPIO_ACTIVE_HIGH.

@ikerexxe ikerexxe force-pushed the spi-cs-active-high branch 2 times, most recently from aa12a7f to d7682f1 Compare November 19, 2024 08:49
@ikerexxe
Copy link
Contributor Author

You'll need to fix these problems: https://github.com/raspberrypi/linux/actions/runs/11895664817/job/33146805156?pr=6477#step:4:559

The syntax error occurs because you aren't including <dt-bindings/gpio/gpio.h>, which you need for GPIO_ACTIVE_HIGH.

Ok, thank you for the information.

@pelwell
Copy link
Contributor

pelwell commented Nov 19, 2024

The syntax error wasn't the only problem: https://github.com/raspberrypi/linux/actions/runs/11895664817/job/33146805156#step:4:561

The overlay itself is now fine, but you need entries in the README and the Makefile.

You may find it helpful to install overlaycheck from our utils repo: https://github.com/raspberrypi/utils/tree/master/overlaycheck

The documentation isn't very clear explaining how to enable SPI CS
active-high and it takes a long time to understand it. Adding a specific
overlay as a simple example on how to invert this signal can help
understand the solution.

Link: https://forums.raspberrypi.com/viewtopic.php?t=378222
Signed-off-by: Iker Pedrosa <[email protected]>
@ikerexxe
Copy link
Contributor Author

Yeah, that helped a lot

@pelwell pelwell merged commit dbf1279 into raspberrypi:rpi-6.6.y Nov 19, 2024
11 of 12 checks passed
popcornmix added a commit to raspberrypi/firmware that referenced this pull request Nov 20, 2024
See: raspberrypi/linux#6463

kernel: dtoverlays: enable SPI CS active-high
See: raspberrypi/linux#6477

kernel: drivers: media: pci: Update Hailo accelerator device driver to v4.19
See: raspberrypi/linux#6478

kernel: misc: rp1-pio: Add FIFO-related methods
See: raspberrypi/linux#6470
popcornmix added a commit to raspberrypi/rpi-firmware that referenced this pull request Nov 20, 2024
See: raspberrypi/linux#6463

kernel: dtoverlays: enable SPI CS active-high
See: raspberrypi/linux#6477

kernel: drivers: media: pci: Update Hailo accelerator device driver to v4.19
See: raspberrypi/linux#6478

kernel: misc: rp1-pio: Add FIFO-related methods
See: raspberrypi/linux#6470
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants