feat: move to ESM #29

tefkah · 2022-04-04T21:02:38Z

Updates all the uniorg packages to use and work with the latest versions of the unified ecosystem, which all solely use Ecmascript modules.

Additionally I added some stricter typings to uniorg-rehype.

Everything works, passes all tests, just need to add a tag!

@types/jest * orgast-util-to-string: ^26.0.23 → 27.4.1 * orgast-util-visit-ids: ^26.0.23 → 27.4.1 * uniorg-attach: ^26.0.23 → 27.4.1 * uniorg-extract-keywords: ^26.0.23 → 27.4.1 * uniorg-parse: ^26.0.20 → 27.4.1 * uniorg-rehype: ^26.0.20 → 27.4.1 * uniorg-slug: ^26.0.23 → 27.4.1 * uniorg-stringify: ^26.0.23 → 27.4.1

unified * blog-starter: ^9.2.0 → 10.1.2 * example: ^9.2.0 → 10.1.2 * extract-keywords-example: ^9.2.1 → 10.1.2 * org-braindump: ^9.2.0 → 10.1.2 * uniorg-attach: ^9.2.1 → 10.1.2 * uniorg-extract-keywords: ^9.2.1 → 10.1.2 * uniorg-rehype: ^9.2.0 → 10.1.2 * uniorg-slug: ^9.2.1 → 10.1.2 * uniorg-stringify: ^9.2.1 → 10.1.2

jest * orgast-util-to-string: ^26.6.3 → 27.5.1 * orgast-util-visit-ids: ^26.6.3 → 27.5.1 * uniorg-attach: ^26.6.3 → 27.5.1 * uniorg-extract-keywords: ^26.6.3 → 27.5.1 * uniorg-parse: ^26.6.3 → 27.5.1 * uniorg-rehype: ^26.6.3 → 27.5.1 * uniorg-slug: ^26.6.3 → 27.5.1 * uniorg-stringify: ^26.6.3 → 27.5.1

tefkah · 2022-04-05T08:25:14Z

Alright I give up for now, maybe you can have a look at why this fails @rasendubi ? I'm going insane

PS. Sorry for all the notifications!

rasendubi · 2022-04-05T14:06:40Z

😂😂😂 sure man, I'll take a look this week. maybe tonight

This reverts commit 6c42331. This is not related to ESM support and doesn't match org-elements API.

ESM does not try to guess file extensions, so have to specify one.

vfile-rename simply doesn't work for some reason.

codecov-commenter · 2022-04-10T00:44:53Z

Codecov Report

Merging #29 (b6490ff) into master (3cefeb8) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   95.66%   95.70%   +0.04%     
==========================================
  Files          14       15       +1     
  Lines        1544     1606      +62     
  Branches      493      515      +22     
==========================================
+ Hits         1477     1537      +60     
- Misses         66       68       +2     
  Partials        1        1

Impacted Files	Coverage Δ
packages/uniorg-parse/src/utils.ts	`100.00% <ø> (+1.78%)`	⬆️
packages/orgast-util-visit-ids/src/index.ts	`100.00% <100.00%> (ø)`
packages/uniorg-attach/src/index.ts	`100.00% <100.00%> (ø)`
packages/uniorg-extract-keywords/src/index.ts	`100.00% <100.00%> (ø)`
packages/uniorg-parse/src/parser.ts	`94.86% <100.00%> (+0.04%)`	⬆️
packages/uniorg-parse/src/reader.ts	`96.10% <100.00%> (-0.96%)`	⬇️
packages/uniorg-rehype/src/index.ts	`100.00% <100.00%> (ø)`
packages/uniorg-rehype/src/org-to-hast.ts	`97.58% <100.00%> (-0.40%)`	⬇️
packages/uniorg-rehype/src/unified-org-rehype.ts	`100.00% <100.00%> (ø)`
packages/uniorg-slug/src/index.ts	`100.00% <100.00%> (ø)`
... and 11 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

rasendubi · 2022-04-10T02:23:54Z

uniorg v0.5.0 is now ESM-only 🎉

@ThomasFKJorna thank you for doing most of the migration, and congrats on your second PR!

tefkah · 2022-04-10T10:17:42Z

Fantastic! Did you manage to figure out why the builds were all failing?

tefkah · 2022-04-10T10:18:34Z

Oh and sorry for leaving the org cite types in, I was working on that separately but mixed those commits in somehow 😅

I would like to add separate support for those if you're okay with that, currently citations such as [cite//b:@Shech2019] aren't picked up by uniorg (unless you add the link types separately of course, but thats a bit of a chore), plus I think providing richer data for citations is useful when writing converters (I'm writing a uniorg-remark one atm).

rasendubi · 2022-04-10T15:29:23Z

Fantastic! Did you manage to figure out why the builds were all failing?

well, yeah. there were many issues:

Some dependencies have broken semantic versioning, so you couldn't even build master: Update dependencies #31
The setup-node github action was outdated, so just setting node version to 16.x didn't work. chore(ci): update nodejs to 16 in CI #32
With node-16, lerna has some bizzare issue when working in CI environment — it simply did not install dependencies. (You could reproduce this with export CI=1.) That's why you would see build not finding dependencies and types. Fixed this by forcing lerna bootstrap --no-ci.
The vercel still used node-12, so org-braindump/org-blog-started jobs failed.

re citation support: I'm absolutely for it! I even started working on it before the war. I don't remember where I stopped, but here are my stashed changes: #33. You can pick them up (use org-element.el as inspiration) and I'll try to help in a week or two

tefkah added 28 commits March 19, 2022 18:27

feat(org-cite): add org-cite types

6c42331

feat(esm): change package locks

ab4269d

feat(esm): change compile target to esm

8792baa

feat(esm): make build succesful with esm target

52633d5

feat(esm): recklessly update all unified deps

6828920

feat(esm): make uniorg-parse compile

16b4e2a

fix(esm): add ignores to uniorg-rehype for now

cfb0a56

fix(esm): make tests run

74c3e92

fix(esm): make tests run

8276c9c

fix: fix most import bugs

7df5354

fix: make org-stringify pass test by ignoring incorrect property

6b064f7

fix: make uniorg slug run by expecting error

6ea8a73

fix: type issues in org-to-hast

0c2f2fb

fix: type of org2rehype plugin

f8eb6ee

fix: fix uniorg-rehype types

1711676

fix: uniorg-parse types

cf9d130

fix: remove fixed ts-expect-error uniorg-slug

d3999b1

fix: fix types orgast-util-to-string

fd51ac1

fix: add possible type in org-parse

97c9e1e

fix: make code not have children

1d75f67

revert: make code have children

db562ef

fix: actually fix types orgast-util-to-string

797d349

fix: pass all tests

ed1b8a3

fix: change old apis in examples

d24250b

fix: update lock file

5026307

vercel bot had a problem deploying to Preview – org-braindump April 4, 2022 21:05 Failure

vercel bot had a problem deploying to Preview – org-blog-starter April 4, 2022 21:05 Failure

rasendubi added 6 commits April 10, 2022 02:18

Merge remote-tracking branch 'origin/feat/esm' into 'origin/master'

0c5ef06

Revert "feat(org-cite): add org-cite types"

64c2643

This reverts commit 6c42331. This is not related to ESM support and doesn't match org-elements API.

docs: remove the note about ESM

6c48632

fix: specify file extension in all relative imports

e3a36df

ESM does not try to guess file extensions, so have to specify one.

fix(org-braindump): fix file renaming

08ae355

vfile-rename simply doesn't work for some reason.

fix(extract-keywords-example): fix example

861e797

vercel bot had a problem deploying to Preview – org-blog-starter April 10, 2022 00:40 Failure

vercel bot had a problem deploying to Preview – org-braindump April 10, 2022 00:40 Failure

vercel bot had a problem deploying to Preview – org-braindump April 10, 2022 01:16 Failure

vercel bot had a problem deploying to Preview – org-blog-starter April 10, 2022 01:19 Failure

vercel bot deployed to Preview – org-blog-starter April 10, 2022 01:27 View deployment

vercel bot deployed to Preview – org-braindump April 10, 2022 01:27 View deployment

vercel bot deployed to Preview – org-blog-starter April 10, 2022 01:34 View deployment

vercel bot deployed to Preview – org-braindump April 10, 2022 01:34 View deployment

rasendubi marked this pull request as ready for review April 10, 2022 01:35

rasendubi added 2 commits April 10, 2022 04:54

refactor: cleanup

5886deb

fix: Paragraph is not a GreaterElement

b6490ff

rasendubi force-pushed the feat/esm branch from f661c05 to b6490ff Compare April 10, 2022 01:55

vercel bot deployed to Preview – org-braindump April 10, 2022 01:55 View deployment

vercel bot deployed to Preview – org-blog-starter April 10, 2022 01:55 View deployment

rasendubi merged commit 0b6ce48 into master Apr 10, 2022

rasendubi deleted the feat/esm branch March 23, 2023 05:16

josephmturner mentioned this pull request Jan 21, 2024

Add org-mode renderer AgregoreWeb/extension-agregore-renderer#8

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: move to ESM #29

feat: move to ESM #29

tefkah commented Apr 4, 2022

tefkah commented Apr 5, 2022

rasendubi commented Apr 5, 2022 via email

codecov-commenter commented Apr 10, 2022 •

edited

Loading

rasendubi commented Apr 10, 2022

tefkah commented Apr 10, 2022

tefkah commented Apr 10, 2022 •

edited

Loading

rasendubi commented Apr 10, 2022

feat: move to ESM #29

feat: move to ESM #29

Conversation

tefkah commented Apr 4, 2022

tefkah commented Apr 5, 2022

rasendubi commented Apr 5, 2022 via email

codecov-commenter commented Apr 10, 2022 • edited Loading

Codecov Report

rasendubi commented Apr 10, 2022

tefkah commented Apr 10, 2022

tefkah commented Apr 10, 2022 • edited Loading

rasendubi commented Apr 10, 2022

codecov-commenter commented Apr 10, 2022 •

edited

Loading

tefkah commented Apr 10, 2022 •

edited

Loading