Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vFile dependency to 5.3.0 version #27

Closed
Artawower opened this issue Feb 13, 2022 · 5 comments · Fixed by #29
Closed

Update vFile dependency to 5.3.0 version #27

Artawower opened this issue Feb 13, 2022 · 5 comments · Fixed by #29

Comments

@Artawower
Copy link

Right now the version of vFile inside uniorg is compatible with to-vfile 6.1.0, but the latest version of to-vfile is 7.3.0, which is incompatible with vFile 4.2.1, because this version has incompatible types.

image

@rasendubi
Copy link
Owner

rasendubi commented Feb 13, 2022 via email

@Artawower
Copy link
Author

Sorry for the inconvenience, I did not find this issue by searching. No, there is no problem with the downgrade, everything is fine and I already did it. Just wanted to notify you 🙂.

@rasendubi
Copy link
Owner

rasendubi commented Feb 13, 2022 via email

@tefkah
Copy link
Collaborator

tefkah commented Mar 19, 2022

If you can use the help, I'd love to help hasten this transition! I've recently been working on a monorepo for some (or quite a few 😅) unified modules in ESM, so I'm somewhat familiar with the challenges this brings (especially with Jest, dear god). Although I'm not certain about the specifics with respect to what this would break specifically, but given that uniorg has been relatively stable for a while I think it would be fine to make a breaking change towards ESM modules.

I would personally also love to be up to date with the rest of the unified ecosystem, as finding the last "safe"/commonjs version of every package every time isn't that great of an experience hahaha.

@rasendubi
Copy link
Owner

@ThomasFKJorna yeah, let’s do this! uniorg is thoroughly tested, so if tests pass, it should be fine. If you want to work on this, you can push a WIP branch and I’ll try to help

@tefkah tefkah linked a pull request Apr 4, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants