-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vFile dependency to 5.3.0 version #27
Comments
Yes. See #24
Is there anything preventing you from downgrading vfile?
|
Sorry for the inconvenience, I did not find this issue by searching. No, there is no problem with the downgrade, everything is fine and I already did it. Just wanted to notify you 🙂. |
Yeah, no worries. And thanks—it might be a good time to re-visit ESM
support soon
|
If you can use the help, I'd love to help hasten this transition! I've recently been working on a monorepo for some (or quite a few 😅) unified modules in ESM, so I'm somewhat familiar with the challenges this brings (especially with Jest, dear god). Although I'm not certain about the specifics with respect to what this would break specifically, but given that uniorg has been relatively stable for a while I think it would be fine to make a breaking change towards ESM modules. I would personally also love to be up to date with the rest of the unified ecosystem, as finding the last "safe"/commonjs version of every package every time isn't that great of an experience hahaha. |
@ThomasFKJorna yeah, let’s do this! uniorg is thoroughly tested, so if tests pass, it should be fine. If you want to work on this, you can push a WIP branch and I’ll try to help |
Right now the version of vFile inside uniorg is compatible with to-vfile 6.1.0, but the latest version of to-vfile is 7.3.0, which is incompatible with vFile 4.2.1, because this version has incompatible types.
The text was updated successfully, but these errors were encountered: