Rename Form to Loop event

[wochinge]

As part of the RulePolicy refactoring, we introduced the concept of a Loop which represents conversation parts which are

• unfeaturized to ML policies
• which are driven by hardcoded rules / if and elses

In contrast Forms to request information from the user and fill required slots.

This means every Form is a Loop, but not every Loop is a Form. E.g. the TwoStageFallback was implemented using the Loop concept but it's not a Form.

• Rename the Form event to Loop event
• make sure that old Form events can still be retrieved from the tracker stores
• adapt Rasa X frontend
• adapt Rasa X backend active_form not required (the tests which involve this are commented out anyway)
• enable Rasa SDK to parse active_loop events

[wochinge]

@mjaycub Do you know if there is any special handlings for Rasa Open Source form events in the frontend? form events are events like user or bot. Just a different type. I did a text search but couldn't find anything. Or are you using active_form somewhere?

[wochinge]

Found these lines in the frontend, but that seems easy to handle:

• https://github.com/RasaHQ/rasa-x/blob/d7bc3df310f3804bbb87e9196857917ac776b17f/src/rasa-frontend/src/state/messages/reducer.ts#L81
• https://github.com/RasaHQ/rasa-x/blob/d1af2ca753eb017957286eb85f9906a0835b1107/src/rasa-frontend/src/api.ts#L254

[mjaycub]

@wochinge I can have a look tomorrow if you'd like, today is blocked up by IVC work

[wochinge]

That would be great. It's not critical but needs to be done for 2.0 compatibility.

[mjaycub]

@wochinge it doesn't look like we do anything special with form events, and we don't ever seem to use active_form at the moment. I think all we'll need to do is add a type for LoopEvent and make sure we update the isEvent check in ConversationStoryViewer (here) to include a check for loop.

Will I open a PR with these changes?

[wochinge]

Will I open a PR with these changes?

I don't know. Will you? 😄 I'd hold off a bit - could be that also rename FormValidation. I'll give you a heads up 👍

[mjaycub]

don't know. Will you? 😄

Haha, was just curious if you wanted to touch the frontend or if you wanted me to do it! 😄I can do it, just follow up when you thing it's time to do so 👍

[wochinge]

As part of the Form changes in Rasa X we also need to do the changes from renaming the FormValidation event (#6463)

And FORM_PREFIX: https://github.com/RasaHQ/rasa/issues

[mjaycub]

@wochinge @chkoss Since this issue is now closed, please keep me in the loop as we will need to make some updates on the frontend if we rename!

[wochinge]

re-opening this. Doesn't make sense to close it at this stage 👍

[wochinge]

Feel free to wrap this up. Otherwise I can do it when I'm back.