Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support ActiveLoop event / deprecate FormAction #246

Merged
merged 8 commits into from
Aug 21, 2020
Merged

support ActiveLoop event / deprecate FormAction #246

merged 8 commits into from
Aug 21, 2020

Conversation

wochinge
Copy link
Contributor

@wochinge wochinge commented Aug 18, 2020 •
edited
Loading

Proposed changes:

  • Rasa SDK part of Rename Form to Loop event rasa#6409
  • parse Rasa Open Source payloads with active_loop instead of active_form field
  • deprecate active_form field in Tracker class
  • add active_loop field to Tracker class
  • add ActiveLoop event
  • deprecate Form event
  • deprecate FormAction
  • remove some problematic language

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@CLAassistant
Copy link

CLAassistant commented Aug 18, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@wochinge wochinge force-pushed the form-to-loop-event-rename branch from 07598e7 to 00096f5 Compare August 18, 2020 09:52
@wochinge wochinge force-pushed the form-to-loop-event-rename branch from 00096f5 to 0906272 Compare August 18, 2020 10:14
@wochinge wochinge changed the title support ActiveLoop event support ActiveLoop event / deprecate FormAction Aug 18, 2020
@wochinge wochinge requested a review from degiz August 18, 2020 10:15
@wochinge wochinge mentioned this pull request Aug 18, 2020
Closed
5 tasks
degiz
degiz approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@degiz degiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🤖

@wochinge wochinge mentioned this pull request Aug 21, 2020
Closed
2 tasks
@wochinge wochinge merged commit eaba4f1 into master Aug 21, 2020
@wochinge wochinge deleted the form-to-loop-event-rename branch August 21, 2020 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@degiz degiz degiz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wochinge @CLAassistant @degiz