Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActionDeactivateForm should be called ActionDeactivateLoop #6592

Closed
5 tasks done
wochinge opened this issue Sep 7, 2020 · 0 comments · Fixed by #6600
Closed
5 tasks done

ActionDeactivateForm should be called ActionDeactivateLoop #6592

wochinge opened this issue Sep 7, 2020 · 0 comments · Fixed by #6600
Assignees
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@wochinge
Copy link
Contributor

wochinge commented Sep 7, 2020

In line with #6409 the default action for deactivating forms ActionDeactivateForm should be renamed to ActionDeactivateLoop

  • adapt docs
  • rename action class
  • rename action name
  • make sure that action_deactivate_fallback is mapped to new action name + deprecated
  • make sure other default action names still make sense
@wochinge wochinge added type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. area:rasa-oss 🎡 Anything related to the open source Rasa framework priority:normal labels Sep 7, 2020
@wochinge wochinge added this to the 2.0rc1 Rasa Open Source milestone Sep 7, 2020
@wochinge wochinge self-assigned this Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant