-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a bug with unnecessary kwargs
unpacking
#4802
Conversation
Thanks for the PR, we'll give it a review as soon as possible. |
@erohmensing it's the same underlying issue (having an argument called Looking at this function, I think this PR fixes the superficial issue resulting from using the name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix :D, this should indeed not be unpacked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix @mrkaaa Could you please rebase this to go 1.5.x and update the changelog? Thanks 🙏
Proposed changes:
kwargs
unpacking in rasa.test.test_core call from rasa.test.test (see issue Issue with kwargs unpacking in rasa.test() #4798)Status (please check what you already did):
black
(please check Readme for instructions)