Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with kwargs unpacking in rasa.test() #4798

Closed
mrkaaa opened this issue Nov 20, 2019 · 5 comments
Closed

Issue with kwargs unpacking in rasa.test() #4798

mrkaaa opened this issue Nov 20, 2019 · 5 comments
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework status:stale type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@mrkaaa
Copy link
Contributor

mrkaaa commented Nov 20, 2019

Rasa version: 1.4.5

Rasa X version (if used & relevant): not relevant

Python version: 3.7.5

Operating system (windows, osx, ...): osx

Issue:
Passing nlu-related kwargs to rasa.test() function causes fail presumably because of unnecessary kwargs unpacking in test_core() call.

Error (including full traceback):

...
rasa.test(
     model=model_path,
     stories=stories_path,
     nlu_data=nlu_test_path,
     output=results_path,
     kwargs={"errors": True}
)
ERROR:TrainWorker:Action train-rasa-agent failed!
ERROR:TrainWorker:test_core() got an unexpected keyword argument 'errors'
Traceback (most recent call last):
  File "/Users/ruagval/PycharmProjects/chatbot/event_core/workers/train.py", line 52, in user_callback
    model_id, return_message = process_train_message(input_params)
  File "/Users/ruagval/PycharmProjects/chatbot/rasa_custom/train_processor.py", line 150, in process_train_message
    validation_results_tmp_path)
  File "/Users/ruagval/PycharmProjects/chatbot/rasa_custom/train_processor.py", line 175, in evaluate_rasa_agent
    kwargs={"errors": True}
  File "/Users/ruagval/PycharmProjects/venv/lib/python3.7/site-packages/rasa/test.py", line 48, in test
    test_core(model, stories, endpoints, output, **kwargs)
TypeError: test_core() got an unexpected keyword argument 'errors'

Command or request that led to error:

test_core(model, stories, endpoints, output, **kwargs)
@mrkaaa mrkaaa added the type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. label Nov 20, 2019
@sara-tagger
Copy link
Collaborator

Thanks for raising this issue, @tmbo will get back to you about it soon✨

Please also check out the docs and the forum in case your issue was raised there too 🤗

@tmbo
Copy link
Member

tmbo commented Nov 20, 2019

Yes this is a bug. @mrkaaa do you mind providing a PR with a fix?

@tmbo tmbo added the area:rasa-oss 🎡 Anything related to the open source Rasa framework label Nov 20, 2019
@mrkaaa
Copy link
Contributor Author

mrkaaa commented Nov 20, 2019

Yes this is a bug. @mrkaaa do you mind providing a PR with a fix?

@tmbo Sure. Made a PR, pls have a look.

@stale
Copy link

stale bot commented Feb 18, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status:stale label Feb 18, 2020
@stale
Copy link

stale bot commented Feb 27, 2020

This issue has been automatically closed due to inactivity. Please create a new issue if you need more help.

@stale stale bot closed this as completed Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework status:stale type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

No branches or pull requests

3 participants