unfortunate use of kwarg 'kwargs' results in some arguments not having effect #4458
Labels
area:rasa-oss 🎡
Anything related to the open source Rasa framework
difficulty:easy 🦋
help wanted
type:bug 🐛
Inconsistencies or issues which will cause an issue or problem for users or implementors.
type:maintenance 🔧
Improvements to tooling, testing, deployments, infrastructure, code style.
In a couple of places (e.g.
rasa.train
andrasa.core.train
) we have a keyword argument calledkwargs
.This is a confusing name as
**kwargs
is conventionally used to capture 0 or more additional, optional keyword arguments.These function signatures should be changed, either by using a different name for this variable (
additional_arguments
) or by adapting them to use**kwargs
.This also causes the argument
dump_stories
ofrasa.train
to have no effect at all. (See https://forum.rasa.com/t/how-can-i-use-dump-stories-from-script/15433)Update:
Another place where we use
kwargs
as a name for a dict instead of a container for optional keyword arguments israsa/rasa/test.py
Line 37 in bd83681
The text was updated successfully, but these errors were encountered: