Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2client): set organizationguid header by default #330

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

pallabpain
Copy link
Member

@pallabpain pallabpain commented Jul 3, 2024

Description

This PR updates the v2 client to set the organization guid header for all API calls.

Slack Reference: https://rapyuta-robotics.slack.com/archives/C04F6FHF4BS/p1719994868878939

@pallabpain pallabpain requested review from a team as code owners July 3, 2024 12:59
Copy link

github-actions bot commented Jul 3, 2024

🤖 Pull Request Artifacts (#9778333935) 🎉

@pallabpain pallabpain self-assigned this Jul 3, 2024
@pallabpain pallabpain added the 🐛 bug Something isn't working label Jul 3, 2024
@@ -119,7 +119,12 @@ def create_project(self, spec: dict) -> Munch:
Create a new project
"""
url = "{}/v2/projects/".format(self._host)
headers = self._get_auth_header(with_project=False)
headers = self._get_auth_header(with_project=False, with_org=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like for update and delete also with_org is not set. Can we set that as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the client. Please take a look.

@pallabpain pallabpain force-pushed the fix/create-project branch from 1574933 to 9595345 Compare July 5, 2024 19:10
Copy link

github-actions bot commented Jul 5, 2024

🤖 Pull Request Artifacts (#9812649778) 🎉

@pallabpain pallabpain requested review from ankitrgadiya and smrutisenapati and removed request for RomilShah July 8, 2024 03:58
@pallabpain pallabpain changed the title fix(v2client): set organizationguid header in create project fix(v2client): set organizationguid header by default Jul 10, 2024
@pallabpain pallabpain merged commit eaa1185 into devel Jul 10, 2024
6 checks passed
rr-github-ci-user pushed a commit that referenced this pull request Aug 2, 2024
# [8.0.0](v7.6.0...v8.0.0) (2024-08-02)

### Bug Fixes

* **apply:** print file name when there is a parsing error ([413ce94](413ce94))
* **auth:** do not save password in cli config ([08a399c](08a399c))
* **bootstrap:** handle exceptions thrown by the cli ([d703df3](d703df3))
* **configtree:** prefix keys with '/' when importing to etcd ([#336](#336)) ([9c74fb5](9c74fb5))
* **configtree:** update sentinel key when tree is imported in etcd ([#337](#337)) ([8ea304b](8ea304b))
* **deployment:** show errors in deployments list ([66f2c7f](66f2c7f))
* **device:** filter uploaded files by name in name_to_request_id ([7348be2](7348be2))
* **jsonschema:** add platform as a product for virtual devices ([#338](#338)) ([6eb50f0](6eb50f0))
* **organization:** fix organization select command ([#339](#339)) ([7943a4a](7943a4a))
* **package:** update the imageTag regex to support semver tags ([#335](#335)) ([6e17408](6e17408))
* **v2client:** set organizationguid header by default ([#330](#330)) ([eaa1185](eaa1185))

### Features

* adds command to list explain examples ([3fc228e](3fc228e))
* **template:** sort rendered templates by file-name ([161ddfc](161ddfc))

### BREAKING CHANGES

* **auth:** The password is no longer saved in the riocli
config.json file.

Wrike Ticket: https://www.wrike.com/open.htm?id=1162009098
@rr-github-ci-user
Copy link
Collaborator

🎉 This PR is included in version 8.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pallabpain pallabpain deleted the fix/create-project branch October 14, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants