fix(configtree): prefix keys with '/' when importing to etcd #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Pull Request Artifacts (#9936496977) 🎉 |
pallabpain
force-pushed
the
fix/configtree-etcd-export
branch
from
d382bdc to
0f30dc7
Compare
pallabpain
commented
Jul 15, 2024
Comment on lines
+36
to
+39
| prefix = prefix or '' | ||
|
|
||
| for key, val in data.items(): | ||
| if prefix: | ||
| key = '{}/{}'.format(prefix, key) | ||
| key = '{}/{}'.format(prefix, key) |
There was a problem hiding this comment.
→ python3
Python 3.10.12 (main, Mar 22 2024, 16:50:05) [GCC 11.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> prefix = None
>>> prefix = prefix or ''
>>> print(prefix)
>>> key = 'master/path/to/key'
>>> key = '{}/{}'.format(prefix, key)
>>> print(key)
/master/path/to/key
>>>
|
🤖 Pull Request Artifacts (#9937251040) 🎉 |
pallabpain
requested review from
amitsingh21,
RomilShah and
ankitrgadiya
and removed request for
RomilShah
amitsingh21
approved these changes
Jul 26, 2024
rr-github-ci-user
pushed a commit
that referenced
this pull request
Aug 2, 2024
# [8.0.0](v7.6.0...v8.0.0) (2024-08-02) ### Bug Fixes * **apply:** print file name when there is a parsing error ([413ce94](413ce94)) * **auth:** do not save password in cli config ([08a399c](08a399c)) * **bootstrap:** handle exceptions thrown by the cli ([d703df3](d703df3)) * **configtree:** prefix keys with '/' when importing to etcd ([#336](#336)) ([9c74fb5](9c74fb5)) * **configtree:** update sentinel key when tree is imported in etcd ([#337](#337)) ([8ea304b](8ea304b)) * **deployment:** show errors in deployments list ([66f2c7f](66f2c7f)) * **device:** filter uploaded files by name in name_to_request_id ([7348be2](7348be2)) * **jsonschema:** add platform as a product for virtual devices ([#338](#338)) ([6eb50f0](6eb50f0)) * **organization:** fix organization select command ([#339](#339)) ([7943a4a](7943a4a)) * **package:** update the imageTag regex to support semver tags ([#335](#335)) ([6e17408](6e17408)) * **v2client:** set organizationguid header by default ([#330](#330)) ([eaa1185](eaa1185)) ### Features * adds command to list explain examples ([3fc228e](3fc228e)) * **template:** sort rendered templates by file-name ([161ddfc](161ddfc)) ### BREAKING CHANGES * **auth:** The password is no longer saved in the riocli config.json file. Wrike Ticket: https://www.wrike.com/open.htm?id=1162009098
|
🎉 This PR is included in version 8.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses a request made by @tetorea that the keys imported in etcd via the CLI do not have a leading
/and that the applications relying on the feature expect the/in the keys that they are reading.To solve the issue, we are adding a
/when a prefix is not specified when importing the keys into etcd.Testing