Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Add spdlog to install export set #886

Merged
merged 4 commits into from
Oct 8, 2021

Conversation

trxcllnt
Copy link
Contributor

@trxcllnt trxcllnt commented Oct 7, 2021

This PR installs spdlog when rmm is installed.

@trxcllnt trxcllnt requested a review from a team as a code owner October 7, 2021 21:18
@github-actions github-actions bot added the CMake label Oct 7, 2021
@trxcllnt trxcllnt added 3 - Ready for review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 7, 2021
@trxcllnt trxcllnt requested a review from harrism October 8, 2021 16:37
@harrism
Copy link
Member

harrism commented Oct 8, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 210e2a1 into rapidsai:branch-21.12 Oct 8, 2021
ajschmidt8 added a commit to ajschmidt8/rmm that referenced this pull request Nov 9, 2021
This PR backports rapidsai#886 to `branch-21.10` in order to install `spdlog` when `rmm` is installed.
ajschmidt8 added a commit that referenced this pull request Nov 9, 2021
This PR backports #886 to `branch-21.10` in order to install `spdlog` when `rmm` is installed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for review Ready for review by team CMake improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants