[FEA] Add option to build faiss shared libs #345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trxcllnt
added
3 - Ready for Review
improvement
…faiss if it's in the raft_FIND_COMPONENTS list
…o fix/build-shared-faiss
|
Closing in favor of #428 |
rapids-bot bot
pushed a commit
to rapidsai/cuml
that referenced
this pull request
Jan 23, 2022
…pendencies from raft (#4256) Depends on rapidsai/raft#345, and CI will be blocked until `raft` is removed from `libcumlprims` install export set. Authors: - Paul Taylor (https://github.com/trxcllnt) - Divye Gala (https://github.com/divyegala) - Ashwin Srinath (https://github.com/shwina) - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: #4256
rapids-bot bot
pushed a commit
to rapidsai/cugraph
that referenced
this pull request
Jan 23, 2022
…1863) Originally this PR was about building FAISS shared libs via CPM, but @rlratzel mentioned cuGraph doesn't need FAISS anymore, and it'd be better if we remove it. If we need FAISS again in the future, we can add `faiss::faiss` back to `target_link_libraries` without needing extra CPM configuration as it will be available [via raft](rapidsai/raft#345). Edit: Removed more dependencies that we inherit from raft and/or rmm. Depends on rapidsai/raft#345. Edit 2: I think the CUDA 11.0 thrust issue will be solved by rapidsai/rapids-cmake#98 Authors: - Paul Taylor (https://github.com/trxcllnt) - Divye Gala (https://github.com/divyegala) Approvers: - Brad Rees (https://github.com/BradReesWork) - AJ Schmidt (https://github.com/ajschmidt8) URL: #1863
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
…pendencies from raft (rapidsai#4256) Depends on rapidsai/raft#345, and CI will be blocked until `raft` is removed from `libcumlprims` install export set. Authors: - Paul Taylor (https://github.com/trxcllnt) - Divye Gala (https://github.com/divyegala) - Ashwin Srinath (https://github.com/shwina) - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#4256
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently blocked by rapidsai/rmm#886 and NVIDIA/cuCollections#104.edit: now just waiting on NVIDIA/cuCollections#104.