Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure nvcomps build and install layouts are consistent #602

Conversation

robertmaynard
Copy link
Contributor

Description

Corrects a bug where the nvcomp packages from the build directory would reference the lib64 layout in the cmake file since that would be the correct layout at install time but not build time.

We now transform the layout of nvcomp to be consistent between build and install

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@robertmaynard robertmaynard added bug Something isn't working non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels May 7, 2024
@robertmaynard robertmaynard requested a review from vyasr May 7, 2024 20:20
@robertmaynard robertmaynard requested a review from a team as a code owner May 7, 2024 20:20
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small question, otherwise looks good.

rapids-cmake/cpm/nvcomp.cmake Show resolved Hide resolved
@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit b465a12 into rapidsai:branch-24.06 May 7, 2024
15 checks passed
@robertmaynard robertmaynard deleted the bug/nvcomp_ensure_build_and_install_layouts_are_consistent branch May 7, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants