Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] nvcomp is not properly linked when libcudf is build as part of cuDF Python #12828

Closed
vyasr opened this issue Feb 22, 2023 · 2 comments
Closed
Labels
2 - In Progress Currently a work in progress bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code.

Comments

@vyasr
Copy link
Contributor

vyasr commented Feb 22, 2023

Describe the bug
When building cuDF Python with FIND_CUDF_CPP=OFF, the build succeeds but the resulting package is not importable. When an import is attempted, it will fail with a linker error indicating that libnvcomp.so is not found. We currently work around this behavior for wheels using a CMake helper function, but ideally this would not be necessary. We should determine why the library paths are not automatically being set correctly. We may just be missing some install rules.

Steps/Code to reproduce bug
Run python setup.py build_ext --inplace -- -DFIND_CUDF_CPP=OFF in the python/cudf directory.

Expected behavior
The above command should generate an importable source directory and not raise any errors

@vyasr vyasr added bug Something isn't working Needs Triage Need team to review and classify labels Feb 22, 2023
@vyasr
Copy link
Contributor Author

vyasr commented Feb 24, 2023

This may be fixed by setting the INSTALL_RPATH_USE_LINK_PATH CMake property

@GregoryKimball GregoryKimball added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue 2 - In Progress Currently a work in progress and removed Needs Triage Need team to review and classify labels Apr 2, 2023
@vyasr
Copy link
Contributor Author

vyasr commented May 15, 2024

There's nothing to do here. We use EXCLUDE_FROM_ALL, so it's expected that libnvcomp won't be installed. rapidsai/rapids-cmake#597 and rapidsai/rapids-cmake#602 ensure that if we did install, libnvcomp would be installed alongside libcudf, which would allow libcudf to see libnvcomp since its RPATH is set to $ORIGIN by default. Once #15483 is done we'll handle installation of these together correctly into a single C++ wheel that can be reused by Python wheels.

@vyasr vyasr closed this as completed May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - In Progress Currently a work in progress bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Development

No branches or pull requests

2 participants