Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rapids_cpm_package_override now hooks into FetchContent #164

Merged
merged 2 commits into from
Apr 11, 2022
Merged

rapids_cpm_package_override now hooks into FetchContent #164

merged 2 commits into from
Apr 11, 2022

Conversation

robertmaynard
Copy link
Contributor

This means that overrides for packages like thrust still work when the caller uses FetchContent, CPMAddPackage, or
rapids_cpm_find instead of rapids_cpm_<pkg>.

Fixes #152

@robertmaynard robertmaynard added feature request New feature or request non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels Mar 16, 2022
@robertmaynard robertmaynard changed the base branch from branch-22.04 to branch-22.06 March 18, 2022 13:10
@robertmaynard
rapids_cpm_package_override now hooks into FetchContent
8d54e6e 
This means that overrides for packages like thrust still work
when the caller uses `FetchContent`, `CPMAddPackage`, or
`rapids_cpm_find` instead of `rapids_cpm_<pkg>`.

Fixes rapidsai#152
@robertmaynard
Correct style issues found by CI
ba1122d
@robertmaynard robertmaynard force-pushed the rapids_cpm_overrides_hooks_into_fetch_content branch from aaa314d to ba1122d Compare March 28, 2022 13:53
@robertmaynard
Copy link
Contributor Author

rerun tests

3 similar comments
@robertmaynard
Copy link
Contributor Author

rerun tests

@robertmaynard
Copy link
Contributor Author

rerun tests

@robertmaynard
Copy link
Contributor Author

rerun tests

@robertmaynard
Copy link
Contributor Author

robertmaynard commented Apr 11, 2022 •
edited
Loading

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 300ae81 into rapidsai:branch-22.06 Apr 11, 2022
@robertmaynard robertmaynard deleted the rapids_cpm_overrides_hooks_into_fetch_content branch April 11, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] rapids_cpm_package_override needs to override any FetchContent project
1 participant
@robertmaynard