Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] rapids_cpm_package_override needs to override any FetchContent project #152

Closed
robertmaynard opened this issue Jan 21, 2022 · 0 comments · Fixed by #164
Closed

[FEA] rapids_cpm_package_override needs to override any FetchContent project #152

robertmaynard opened this issue Jan 21, 2022 · 0 comments · Fixed by #164
Labels
2 - In Progress Currenty a work in progress feature request New feature or request

Comments

@robertmaynard
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Presume the following override.json:

{
  "packages" : {
      "Thrust" : {
        "version" : "1.17.0",
        "git_url" : "https://github.com/NVIDIA/thrust.git",
        "git_tag" : "${version}"
    }
  }
}

When this override exists, any call to rapids_cpm_thrust will use the override. But any call to rapids_cpm_find(Thrust... won't.

Describe the solution you'd like
Instead of having the activation of an override entry occur on the call to rapids_cpm_<pkg> it should happen on rapids_cpm_package_override. For this to work properly with rapids_cpm_find we will need to store the relevant information with FetchContent_Declare
@robertmaynard robertmaynard added feature request New feature or request ? - Needs Triage Need team to review and classify labels Jan 21, 2022
@robertmaynard robertmaynard added 1 - On Deck To be worked on next and removed ? - Needs Triage Need team to review and classify labels Jan 21, 2022
robertmaynard added a commit to robertmaynard/rapids-cmake that referenced this issue Mar 16, 2022
@robertmaynard
rapids_cpm_package_override now hooks into FetchContent
4b569b8 
This means that overrides for packages like thrust still work
when the caller uses `FetchContent`, `CPMAddPackage`, or
`rapids_cpm_find` instead of `rapids_cpm_<pkg>`.

Fixes rapidsai#152
robertmaynard added a commit to robertmaynard/rapids-cmake that referenced this issue Mar 16, 2022
@robertmaynard
rapids_cpm_package_override now hooks into FetchContent
d06aea6 
This means that overrides for packages like thrust still work
when the caller uses `FetchContent`, `CPMAddPackage`, or
`rapids_cpm_find` instead of `rapids_cpm_<pkg>`.

Fixes rapidsai#152
@robertmaynard robertmaynard mentioned this issue Mar 16, 2022
Merged
@robertmaynard robertmaynard added 2 - In Progress Currenty a work in progress and removed 1 - On Deck To be worked on next labels Mar 18, 2022
robertmaynard added a commit to robertmaynard/rapids-cmake that referenced this issue Mar 28, 2022
@robertmaynard
rapids_cpm_package_override now hooks into FetchContent
8d54e6e 
This means that overrides for packages like thrust still work
when the caller uses `FetchContent`, `CPMAddPackage`, or
`rapids_cpm_find` instead of `rapids_cpm_<pkg>`.

Fixes rapidsai#152
@rapids-bot rapids-bot bot closed this as completed in #164 Apr 11, 2022
rapids-bot bot pushed a commit that referenced this issue Apr 11, 2022
@robertmaynard
rapids_cpm_package_override now hooks into FetchContent (#164)
300ae81 
This means that overrides for packages like thrust still work when the caller uses `FetchContent`, `CPMAddPackage`, or
`rapids_cpm_find` instead of `rapids_cpm_<pkg>`.

Fixes #152

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers: None

URL: #164
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 - In Progress Currenty a work in progress feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rapids_cpm_package_override now hooks into FetchContent robertmaynard/rapids-cmake
1 participant
@robertmaynard