Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend rapids_export to support the concept of optional COMPONENTS #154

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Extend rapids_export to support the concept of optional COMPONENTS #154

merged 1 commit into from
Mar 14, 2023

Conversation

robertmaynard
Copy link
Contributor

rapids_export via the COMPONENTS and COMPONENTS_EXPORT_SET commands can now generate find modules that have optional components.

@robertmaynard robertmaynard added feature request New feature or request non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels Jan 25, 2022
@robertmaynard robertmaynard added 5 - DO NOT MERGE Hold off on merging; see PR for details and removed 3 - Ready for Review Ready for review by team labels Mar 16, 2022
@vyasr
Copy link
Contributor

vyasr commented Sep 27, 2022

I assume this is slipping to 22.12 right?

@robertmaynard
Copy link
Contributor Author

I assume this is slipping to 22.12 right?

Yeap

@vyasr vyasr mentioned this pull request Sep 27, 2022
Merged
@vyasr vyasr mentioned this pull request Jan 6, 2023
Closed
@robertmaynard robertmaynard requested review from a team as code owners January 17, 2023 19:48
@robertmaynard robertmaynard force-pushed the fea/export-components branch 4 times, most recently from 2603f6d to 7298a97 Compare January 18, 2023 19:13
@robertmaynard robertmaynard changed the base branch from branch-22.04 to branch-23.02 January 18, 2023 19:19
@robertmaynard robertmaynard added 3 - Ready for Review Ready for review by team and removed 5 - DO NOT MERGE Hold off on merging; see PR for details labels Jan 18, 2023
@robertmaynard robertmaynard removed the request for review from a team January 18, 2023 20:17
@robertmaynard
Copy link
Contributor Author

raft draft pr switching to this feature: rapidsai/raft#1154

@robertmaynard robertmaynard force-pushed the fea/export-components branch 2 times, most recently from 9492d35 to a7a9f39 Compare January 24, 2023 14:59
@robertmaynard
Copy link
Contributor Author

rapidsai/raft#1154 is now passing with the latest updates to the COMPONENT design. Ready for review

@robertmaynard robertmaynard changed the base branch from branch-23.02 to branch-23.04 January 27, 2023 15:26
@robertmaynard robertmaynard force-pushed the fea/export-components branch 2 times, most recently from 66efaaf to d622750 Compare March 9, 2023 20:01
@vyasr
Copy link
Contributor

vyasr commented Mar 10, 2023

@robertmaynard looks like this completely slipped out of my sight. Should I review this now?

@robertmaynard
Copy link
Contributor Author

@robertmaynard looks like this completely slipped out of my sight. Should I review this now?

Yes please

vyasr
vyasr requested changes Mar 10, 2023
View reviewed changes
rapids-cmake/export/export.cmake Outdated Show resolved Hide resolved
rapids-cmake/export/export.cmake Show resolved Hide resolved
rapids-cmake/export/detail/component.cmake Outdated Show resolved Hide resolved
rapids-cmake/export/detail/component.cmake Show resolved Hide resolved
rapids-cmake/export/detail/component.cmake Show resolved Hide resolved
rapids-cmake/export/detail/component.cmake Show resolved Hide resolved
rapids-cmake/export/detail/component.cmake Show resolved Hide resolved
vyasr
vyasr approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions and stylistic changes, and a couple of threads from my last review remain open, but everything that's left is very minor.

testing/export/export-verify-build-components-dependencies/CMakeLists.txt Outdated Show resolved Hide resolved
testing/export/export-verify-build-components-dependencies/CMakeLists.txt Outdated Show resolved Hide resolved
testing/export/export-verify-build-components-dependencies/CMakeLists.txt Outdated Show resolved Hide resolved
testing/export/export-verify-build-components-dependencies/CMakeLists.txt Outdated Show resolved Hide resolved
@robertmaynard
Extend rapids_export to support the concept of optional COMPONENTS
a837d1e 
rapids_export via the COMPONENTS and COMPONENTS_EXPORT_SET commands
can now generate find modules that have optional components.
@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 87d72fb into rapidsai:branch-23.04 Mar 14, 2023
@robertmaynard robertmaynard deleted the fea/export-components branch March 14, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Introduces a non-breaking change
Projects
rapids-cmake
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertmaynard @vyasr