-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
suppress expansion of unused raft spectral templates #2739
Conversation
…nd might be relevant
added labels just so CI will run |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-22.10 #2739 +/- ##
===============================================
Coverage ? 60.04%
===============================================
Files ? 111
Lines ? 6184
Branches ? 0
===============================================
Hits ? 3713
Misses ? 2471
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@gpucibot merge |
# We need to call get_raft due to cuML asking for raft::nn and | ||
# raft::distance targets | ||
# see issue https://github.com/rapidsai/cuml/issues/4843 | ||
include(../../cpp/cmake/thirdparty/get_raft.cmake) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cjnolet good find. The underlying issue here will be fixed by rapidsai/rapids-cmake#154.
For future reference the issue this PR fixes that caused #2707 to fail is that rapids-cmake's export commands don't support |
Closes #2678
raft updated some k-means logic and dramatically increased the compile time of our spectral clustering implementation. This PR adds an include that will suppress the expansion of templates that we are not using.