Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add moto min_version at 1.3.14, update s3fs to 0.5.2 #207

Merged
merged 1 commit into from
Jan 19, 2021
Merged

Add moto min_version at 1.3.14, update s3fs to 0.5.2 #207

merged 1 commit into from
Jan 19, 2021

Conversation

ayushdg
Copy link
Member

@ayushdg ayushdg commented Jan 16, 2021

Pr adds the following:

  • Add minimum dependency for moto to 1.3.14
  • Updates s3fs min version to 0.5.2
  • Enforce s3fs versioning in rapids-build and notebook environments

Required for (and tested on) rapidsai/cudf#7144

@ayushdg ayushdg requested a review from a team as a code owner January 16, 2021 00:58
@ajschmidt8 ajschmidt8 merged commit 42bf717 into rapidsai:branch-0.18 Jan 19, 2021
@ayushdg ayushdg mentioned this pull request Jan 19, 2021
Merged
rapids-bot bot pushed a commit to rapidsai/cudf that referenced this pull request Jan 20, 2021
@ayushdg
Update s3 tests to use moto_server(#7144)
5855bfa 
This PR updates s3 tests to use `moto_server` instead of going via a moto mock_s3 context. This enables cleaner s3 testing with `s3fs>=0.5` which incorporates aiobotocore for s3 connections.


- The pytests starts up a moto-server for each worker running tests. 
- Ports used: `5000, 5550 - 5550+ (n_pytest_workers-1)`

Updated integration repo with requirements: rapidsai/integration#207

Authors:
  - Ayush Dattagupta <[email protected]>

Approvers:
  - GALI PREM SAGAR (@galipremsagar)
  - Keith Kraus (@kkraus14)

URL: #7144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@kkraus14 kkraus14 kkraus14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayushdg @kkraus14 @ajschmidt8