Update s3 tests to use moto_server #7144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayushdg
commented
Jan 14, 2021
kkraus14
added
2 - In Progress
1 task
|
Failing dask-cudf test attributed to changes here: dask/dask#6960 (comment). |
|
@rjzamora's fix in dask/dask#7074 has been merged |
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-0.18 #7144 +/- ##
===============================================
+ Coverage 82.09% 82.11% +0.01%
===============================================
Files 97 97
Lines 16474 16542 +68
===============================================
+ Hits 13524 13583 +59
- Misses 2950 2959 +9
Continue to review full report at Codecov.
|
ayushdg
commented
Jan 15, 2021
ci/gpu/build.sh
Outdated
| # gpuci_conda_retry remove --force rapids-build-env rapids-notebook-env | ||
| # gpuci_conda_retry install -y "your-pkg=1.0.0" | ||
| gpuci_conda_retry remove --force rapids-build-env rapids-notebook-env | ||
| gpuci_conda_retry install -y "s3fs=0.5.2" "boto3" "moto=1.3.14" "httpretty" |
There was a problem hiding this comment.
@kkraus14 Would the next step be to incorporate these changes to https://github.com/rapidsai/integration, revert them here and only merge this PR once the integration is merged?
ayushdg
changed the title
galipremsagar
approved these changes
Jan 19, 2021
kkraus14
approved these changes
Jan 20, 2021
kkraus14
added
5 - Ready to Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates s3 tests to use
moto_serverinstead of going via a moto mock_s3 context. This enables cleaner s3 testing withs3fs>=0.5which incorporates aiobotocore for s3 connections.5000, 5550 - 5550+ (n_pytest_workers-1)Updated integration repo with requirements: rapidsai/integration#207