-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: replacing the obsolete cudf.testing._utils.assert_eq calls #706
Tests: replacing the obsolete cudf.testing._utils.assert_eq calls #706
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @madsbk !
Thanks @pentschev, I suspect that the last CI errors will be fixed with rapidsai/cudf#9031 |
@gpucibot merge |
rerun tests |
Prem has a fix in PR ( dask/dask#8055 ) |
@jakirkham no, that doesn't fix it. I've commented about it in #705 (comment) and chatted with him offline, he's gonna take a look at it. |
Just to confirm, did you see this change ( dask/dask#8055 (review) )? |
Yes, I just tested that PR locally (specifically the current latest commit dask/dask@4202401) and the dask-cuda still fail in my local environment. |
Ok thanks. Noted that in the PR |
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #706 +/- ##
================================================
+ Coverage 87.63% 89.42% +1.78%
================================================
Files 15 15
Lines 1658 1692 +34
================================================
+ Hits 1453 1513 +60
+ Misses 205 179 -26
Continue to review full report at Codecov.
|
Using
from dask.dataframe.utils import assert_eq
instead