Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Add support for percentile dispatch in dask_cudf #9031

Merged
merged 4 commits into from
Aug 17, 2021
Merged

[REVIEW] Add support for percentile dispatch in dask_cudf #9031

merged 4 commits into from
Aug 17, 2021

Conversation

galipremsagar
Copy link
Contributor

This PR adds support for percentile dispatch in dask_cudf.

Upstream changes needed: dask/dask#8029

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team 4 - Needs Dask Reviewer non-breaking Non-breaking change labels Aug 12, 2021
@galipremsagar galipremsagar requested a review from a team as a code owner August 12, 2021 22:23
@galipremsagar galipremsagar requested a review from a team as a code owner August 12, 2021 22:23
@github-actions github-actions bot added the Python Affects Python cuDF API. label Aug 12, 2021
@shwina shwina mentioned this pull request Aug 12, 2021
Merged
3 tasks
@galipremsagar galipremsagar linked an issue Aug 13, 2021 that may be closed by this pull request
[BUG] Datetime and TimeDelta Columns incorrectly return result for .values #9023
Closed
marlenezw
marlenezw approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@marlenezw marlenezw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, just a minor suggestion.

python/dask_cudf/dask_cudf/backends.py Show resolved Hide resolved
@quasiben
Copy link
Member

rerun tests

quasiben
quasiben approved these changes Aug 17, 2021
View reviewed changes
Copy link
Member

@quasiben quasiben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @galipremsagar!

@galipremsagar galipremsagar self-assigned this Aug 17, 2021
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs Dask Reviewer labels Aug 17, 2021
@codecov
Copy link

codecov bot commented Aug 17, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@368890f). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 323fb8b differs from pull request most recent head 87c97f5. Consider uploading reports for the commit 87c97f5 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #9031   +/-   ##
===============================================
  Coverage                ?   10.71%           
===============================================
  Files                   ?      114           
  Lines                   ?    19088           
  Branches                ?        0           
===============================================
  Hits                    ?     2046           
  Misses                  ?    17042           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 368890f...87c97f5. Read the comment docs.

@jrbourbeau jrbourbeau mentioned this pull request Aug 17, 2021
Merged
3 tasks
@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 5f1b7f2 into rapidsai:branch-21.10 Aug 17, 2021
@madsbk madsbk mentioned this pull request Aug 18, 2021
Merged
@jrbourbeau jrbourbeau mentioned this pull request Aug 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marlenezw marlenezw marlenezw approved these changes

@quasiben quasiben quasiben approved these changes

@skirui-source skirui-source Awaiting requested review from skirui-source

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Datetime and TimeDelta Columns incorrectly return result for .values
3 participants
@galipremsagar @quasiben @marlenezw