Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle more RAPIDS version formats in update-version.sh, refactor dependencies.yaml #1329

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

jameslamb
Copy link
Member

Description

Contributes to rapidsai/build-planning#13.

Updates update-version.sh to correctly handle RAPIDS dependencies like cudf-cu12==24.2.*.

This also pulls in some dependency refactoring originally added in #1320, which allows greater use of dependencies.yaml globs (and therefore less maintenance effort to support new CUDA versions).

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

How I tested this

The portability of this updated sed command was tested here: rapidsai/cudf#14825 (comment).

In this repo, I ran the following:

./ci/release/update-version.sh '23.12.00'
git diff

./ci/release/update-version.sh '24.04.00'
git diff

Confirmed that that first git diff changed all the things I expected, and that second one showed 0 changes.

@jameslamb jameslamb requested a review from a team as a code owner January 23, 2024 15:27
@github-actions github-actions bot added the ci label Jan 23, 2024
@jameslamb jameslamb added 3 - Ready for Review Ready for review by team non-breaking Non-breaking change improvement Improvement / enhancement to an existing function bug Something isn't working and removed improvement Improvement / enhancement to an existing function labels Jan 23, 2024
@jameslamb
Copy link
Member Author

These CI failures:

>       return DataFrame._from_columns(result, range(num_spaces))
E       AttributeError: type object 'DataFrame' has no attribute '_from_columns'. Did you mean: '_drop_column'?

(build link)

Are because cuspatial relies on a private API in cudf, which was removed in rapidsai/cudf#14755.

Looks like #1326 will fix that.

@jameslamb
Copy link
Member Author

The failing devcontainer build with this:

  [2024-01-23T15:32:32.084Z] ERROR: Cannot install -r /tmp/rapids.requirements.txt (line 5) and cudf-cu12==24.4.* because these package versions have conflicting dependencies.
  
  The conflict is caused by:
      The user requested cudf-cu12==24.4.*
      cuml-cu12 24.4.0a0 depends on cudf-cu12==24.2.* and >=0.0.0a0

  [2024-01-23T15:32:32.085Z] ERROR: ResolutionImpossible

(build link)

Should be fixed by rapidsai/cuml#5726.

@vyasr
Copy link
Contributor

vyasr commented Jan 25, 2024

/merge

@rapids-bot rapids-bot bot merged commit 5e0cb36 into rapidsai:branch-24.04 Jan 25, 2024
61 checks passed
@jameslamb jameslamb deleted the update-version branch January 26, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working ci non-breaking Non-breaking change
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants