-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use _from_data instead of _from_columns for initialzing Frame #14755
Use _from_data instead of _from_columns for initialzing Frame #14755
Conversation
A bit of background for |
Is this still an effort being worked on? My observation of the current usage is that it tends to always be paired with column labels like |
If I remember correctly, the remaining work to be done are cuio cython APIs. But this work shouldn't be block by that, in fact, follow ups to that refactor can always resort to |
/merge |
This work was put on hold because I decided that getting pylibcudf done first would be better. Most of the structure that I imagined imposing at the Cython layer will be largely informed by refactoring cudf internals around pylibcudf objects once pylibcudf is done. |
Description
In the spirit of reducing redundant methods,
_from_columns
just calls_from_data
(hoping to rename to_from_mapping
or similar) so removing the need for_from_columns
.Hoping to do the same for the
_from_columns_like_self
in a follow up.Checklist