Fix the CMake option for disabling deprecation warnings. #4946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
bug
3 tasks
robertmaynard
approved these changes
Oct 25, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #4946 +/- ##
===============================================
Coverage ? 79.46%
===============================================
Files ? 183
Lines ? 11618
Branches ? 0
===============================================
Hits ? 9232
Misses ? 2386
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@gpucibot merge |
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Oct 25, 2022
…#11989) Use the term `DISABLE_DEPRECATION_WARNINGS` so that we match other RAPIDS projects rapidsai/cuml#4946 plus the plural tense in general makes more sense. Authors: - Robert Maynard (https://github.com/robertmaynard) - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Bradley Dice (https://github.com/bdice) - Vyas Ramasubramani (https://github.com/vyasr) URL: #11989
jakirkham
pushed a commit
to jakirkham/cuml
that referenced
this pull request
Feb 27, 2023
The actual option is `DISABLE_DEPRECATION_WARNINGS` but everywhere in the code base is currently making use of `DISABLE_DEPRECATION_WARNING` (note the singular rather than the plural). Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Robert Maynard (https://github.com/robertmaynard) URL: rapidsai#4946
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual option is
DISABLE_DEPRECATION_WARNINGSbut everywhere in the code base is currently making use ofDISABLE_DEPRECATION_WARNING(note the singular rather than the plural).