[REVIEW] Improved Array Conversion with CumlArrayDescriptor and Decorators [skip-ci] #3040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…os where a function returns CumlArray
…mlarray-use-improved
…allow setting Base values in constructor
…mlarray-use-improved
…mlarray-use-improved
…mlarray-use-improved
…mlarray-use-improved
dantegd
requested changes
Nov 9, 2020
dantegd
requested changes
Nov 10, 2020
Co-authored-by: Dante Gama Dessavre <[email protected]>
…t-nv/cuml into bug-audit-cumlarray-use-improved
mdemoret-nv
changed the title
Co-authored-by: Dante Gama Dessavre <[email protected]>
…mlarray-use-improved
JohnZed
reviewed
Nov 11, 2020
dantegd
requested changes
Nov 12, 2020
JohnZed
approved these changes
Nov 13, 2020
dantegd
approved these changes
Nov 13, 2020
|
rerun tests |
JohnZed
changed the title
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the large number of input and output array types that cuml supports, the library needs to be flexible in how array data is handed when entering and exiting the API. This has led to some inconsistent usage of
CumlArray, unnecessary conversions and memcpys, and adds repeated work for the developers.This PR helps with these issues by adding a new object
CumlArrayDescriptorand a set of decorators incuml.internalsthat make working with array data easier for developers and more consistent for users, while still being flexible enough to handle any scenario. Finally, this PR updates the majority of the code base to be consistent and use the new features.A detailed description of the new features, how to use them, and whats going on internally, can be found in the new Estimator Guide.
Note: While the number of changed files is very large, the meat of the new features is limited to 2 sections. The rest of the changes are updates to use the new features and are very repetitive and formulaic.