Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Switch to rmm.to_device in RegressorMixin #1092

Closed
jakirkham opened this issue Sep 11, 2019 · 2 comments
Closed

[BUG] Switch to rmm.to_device in RegressorMixin #1092

jakirkham opened this issue Sep 11, 2019 · 2 comments
Labels
? - Needs Triage Need team to review and classify bug Something isn't working Cython / Python Cython or Python issue

Comments

@jakirkham
Copy link
Member

Recently we tried to use rmm.to_device in RegressorMixin as part of the move to handle GPU array-like objects in PR ( #1086 ). However we encountered some issues using rmm.to_device with cuDF Series objects. ( rapidsai/rmm#129 ) As a result, we used numba.to_device instead, which didn't have this issue. Though ultimately we would like to switch to using rmm.to_device once that is viable.
@jakirkham jakirkham added ? - Needs Triage Need team to review and classify bug Something isn't working labels Sep 11, 2019
@jakirkham jakirkham mentioned this issue Sep 11, 2019
Merged
@dantegd dantegd added the Cython / Python Cython or Python issue label Sep 11, 2019
@jakirkham
Copy link
Member Author

Guessing the right way to resolve this today would be to use CumlArray.

@beckernick
Copy link
Member

This has been resolved by a combination of #2411 and #3040

Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
? - Needs Triage Need team to review and classify bug Something isn't working Cython / Python Cython or Python issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dantegd @jakirkham @beckernick