Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors compiling for DLFW on CUDA 12.3 #3952

Merged
merged 5 commits into from
Oct 31, 2023
Merged

Errors compiling for DLFW on CUDA 12.3 #3952

merged 5 commits into from
Oct 31, 2023

Conversation

ChuckHastings
Copy link
Collaborator

DLFW compilation found a few issues building cugraph 23.10.

This PR addresses these issues. Two main issues:

  • We were brace initializing raft::device_span objects with only nullptr. The device span already defaults to nullptr, and the class hierarchy doesn't support just passing nullptr.
  • We were brace initializing the raft::random::DeviceState, but there's no default constructor. Changed it to not brace initialize and require a reference to make it clear that you must initialize the DeviceState.

@ChuckHastings ChuckHastings marked this pull request as ready for review October 23, 2023 20:23
@ChuckHastings ChuckHastings requested a review from a team as a code owner October 23, 2023 20:23
@ChuckHastings ChuckHastings self-assigned this Oct 23, 2023
@ChuckHastings ChuckHastings added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 23, 2023
seunghwak
seunghwak approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BradReesWork
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 35875a8 into rapidsai:branch-23.12 Oct 31, 2023
79 checks passed
@ChuckHastings ChuckHastings deleted the fix_dlfw_issues branch December 1, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seunghwak seunghwak seunghwak approved these changes

@robertmaynard robertmaynard robertmaynard approved these changes

Assignees

@ChuckHastings ChuckHastings

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ChuckHastings @BradReesWork @robertmaynard @seunghwak @nv-rliu