-
Notifications
You must be signed in to change notification settings - Fork 304
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Errors compiling for DLFW on CUDA 12.3 (#3952)
DLFW compilation found a few issues building cugraph 23.10. This PR addresses these issues. Two main issues: * We were brace initializing `raft::device_span` objects with only `nullptr`. The device span already defaults to `nullptr`, and the class hierarchy doesn't support just passing `nullptr`. * We were brace initializing the `raft::random::DeviceState`, but there's no default constructor. Changed it to not brace initialize and require a reference to make it clear that you must initialize the DeviceState. Authors: - Chuck Hastings (https://github.com/ChuckHastings) - Ralph Liu (https://github.com/nv-rliu) Approvers: - Seunghwa Kang (https://github.com/seunghwak) - Robert Maynard (https://github.com/robertmaynard) URL: #3952
- Loading branch information
1 parent
9755022
commit 35875a8
Showing
2 changed files
with
13 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters