Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding data to PropertyGraph that already has indices set #3175

Merged
merged 7 commits into from
Feb 22, 2023

Conversation

eriknw
Copy link
Contributor

@eriknw eriknw commented Jan 24, 2023

Allow indices to already be set when adding vertex data or edge data to [MG]PropertyGraph. Closes #3111.

I still need to update docstrings and should add a couple more tests.

@eriknw eriknw requested a review from a team as a code owner January 24, 2023 05:41
@eriknw eriknw marked this pull request as draft January 24, 2023 05:45
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2023

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.04@a0d964d). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-23.04    #3175   +/-   ##
===============================================
  Coverage                ?   56.21%           
===============================================
  Files                   ?      153           
  Lines                   ?     9691           
  Branches                ?        0           
===============================================
  Hits                    ?     5448           
  Misses                  ?     4243           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BradReesWork BradReesWork added this to the 23.04 milestone Jan 24, 2023
@alexbarghi-nv alexbarghi-nv added feature request New feature or request non-breaking Non-breaking change labels Jan 24, 2023
@eriknw eriknw marked this pull request as ready for review January 25, 2023 06:02
@alexbarghi-nv alexbarghi-nv assigned eriknw and unassigned rlratzel and jnke2016 Jan 25, 2023
@eriknw eriknw requested review from a team as code owners February 7, 2023 06:48
@eriknw eriknw changed the base branch from branch-23.02 to branch-23.04 February 8, 2023 02:08
@ajschmidt8 ajschmidt8 removed the request for review from a team February 8, 2023 16:42
@ajschmidt8
Copy link
Member

Removing ops-codeowners from the required reviews since it doesn't seem there are any file changes that we're responsible for. Feel free to add us back if necessary.

@rlratzel rlratzel removed the request for review from a team February 22, 2023 16:12
@rlratzel
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 965abe9 into rapidsai:branch-23.04 Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA]: Allow data added to PropertyGraph to have IDs already as the index
7 participants