Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA]: Allow data added to PropertyGraph to have IDs already as the index #3111

Closed
2 tasks done
Tracked by #12
, #3254
...
eriknw opened this issue Jan 5, 2023 · 0 comments · Fixed by #3175
Closed
2 tasks done
Tracked by #12
, #3254
...

[FEA]: Allow data added to PropertyGraph to have IDs already as the index #3111

eriknw opened this issue Jan 5, 2023 · 0 comments · Fixed by #3175
Assignees
@eriknw
Labels
feature request New feature or request
Milestone
23.04

Comments

@eriknw
Copy link
Contributor

eriknw commented Jan 5, 2023

Is this a new feature, an improvement, or a change to existing functionality?

Improvement

How would you describe the priority of this feature request

Medium

Please provide a clear description of problem this feature solves

Loading data with PropertyGraph--and especially MGPropertyGraph--is sometimes slower than necessary. It would often be faster if edge and vertex data could be added that already has the index set correctly to IDs. This can prevent a "set index" operation for MGPropertyGraph.

Describe your ideal solution

Allow e.g. vertex_col_name in add_vertex_data to indicate the index name. This can be added to the API without changing the signature or affecting current usage.

Describe any alternatives you have considered

No response

Additional context

No response

Code of Conduct

  • I agree to follow cuGraph's Code of Conduct
  • I have searched the open feature requests and have found no duplicates for this feature request
@eriknw eriknw added ? - Needs Triage Need team to review and classify feature request New feature or request labels Jan 5, 2023
@alexbarghi-nv alexbarghi-nv added this to the 23.02 milestone Jan 5, 2023
@BradReesWork BradReesWork removed the ? - Needs Triage Need team to review and classify label Jan 5, 2023
@BradReesWork BradReesWork modified the milestones: 23.02, 23.04 Jan 23, 2023
@eriknw eriknw mentioned this issue Jan 24, 2023
Merged
@kingmesal kingmesal mentioned this issue Feb 8, 2023
Closed
rapids-bot bot pushed a commit that referenced this issue Feb 22, 2023
@eriknw
Allow adding data to PropertyGraph that already has indices set (#3175)
965abe9 
Allow indices to already be set when adding vertex data or edge data to [MG]PropertyGraph. Closes #3111.

I still need to update docstrings and should add a couple more tests.

Authors:
  - Erik Welch (https://github.com/eriknw)
  - Alex Barghi (https://github.com/alexbarghi-nv)

Approvers:
  - Rick Ratzel (https://github.com/rlratzel)

URL: #3175
@rlratzel rlratzel mentioned this issue May 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eriknw eriknw

Labels
feature request New feature or request
Projects
None yet
Milestone
23.04
Development

Successfully merging a pull request may close this issue.

Allow adding data to PropertyGraph that already has indices set eriknw/cugraph
3 participants
@eriknw @BradReesWork @alexbarghi-nv