Replace PropertyGraph in cugraph-PyG with FeatureStore #3159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with the server, added tests which use/test the new builtin test extensions.
…s (via rapids-pytest-benchmark plugin) easier to read, changes to allow RemoteGraph to use either a server-side Graph or PropertyGraph.
…r LocalCUDACluster for MG service, re-wrote start list generation to work with both SG and MG, added server extension for generating start list, changed scale from 24 to 23 to prevent OOM, added separate function for creating MG graphs, added debug print to show result sizes, fixes to cugraph MG Graph for incorrect column names, added util to cugraph for starting and stopping dask client.
…2-initial_service_benchmarks
…2-initial_service_benchmarks
…art so it fails faster, including the stdout/stderr output in the exception raised or to console depending on how it exited.
…chmarks for different libraries.
VibhuJawa
suggested changes
Jan 26, 2023
python/cugraph-pyg/cugraph_pyg/tests/mg/test_mg_cugraph_sampler.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Vibhu Jawa <[email protected]>
VibhuJawa
suggested changes
Jan 26, 2023
rlratzel
approved these changes
Jan 27, 2023
|
/merge |
Codecov ReportBase: 55.22% // Head: 55.31% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #3159 +/- ##
================================================
+ Coverage 55.22% 55.31% +0.08%
================================================
Files 148 148
Lines 9543 9553 +10
================================================
+ Hits 5270 5284 +14
+ Misses 4273 4269 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jan 31, 2023
Closes #3152 Depends on #3148 and #3159 This PR does support multiple trainers, even though there is no example for it. Authors: - Alex Barghi (https://github.com/alexbarghi-nv) - Chuck Hastings (https://github.com/ChuckHastings) - Vibhu Jawa (https://github.com/VibhuJawa) Approvers: - Vibhu Jawa (https://github.com/VibhuJawa) - Rick Ratzel (https://github.com/rlratzel) URL: #3170
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces PropertyGraph in cugraph-PyG with the new FeatureStore, which is the preferred solution for storing tensor features.
Closes #3151
Closes #3079