Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] cuGraph-PyG Should Pass Canonical Edge Type to New Uniform Neighbor Sample Function #3079

Closed
alexbarghi-nv opened this issue Dec 14, 2022 · 0 comments · Fixed by #3159
Closed

[FEA] cuGraph-PyG Should Pass Canonical Edge Type to New Uniform Neighbor Sample Function #3079

alexbarghi-nv opened this issue Dec 14, 2022 · 0 comments · Fixed by #3159
Assignees
@alexbarghi-nv
Labels
feature request New feature or request
Milestone
23.02

Comments

@alexbarghi-nv
Copy link
Member

alexbarghi-nv commented Dec 14, 2022 •
edited
Loading

Currently, cuGraph-PyG only passes the cuGraph edge type, but this adds unnecessary overhead. Instead, the canonical edge type should be passed as an integer. A lookup table may need to be added in CuGraphStore to handle this.

Partially resolved by #3101
@alexbarghi-nv alexbarghi-nv added the feature request New feature or request label Dec 14, 2022
@alexbarghi-nv alexbarghi-nv added this to the 23.02 milestone Dec 14, 2022
@alexbarghi-nv alexbarghi-nv self-assigned this Dec 14, 2022
This was referenced Jan 17, 2023
Merged
Merged
rapids-bot bot pushed a commit that referenced this issue Jan 20, 2023
@alexbarghi-nv
Speed Improvements for cuGraph-PyG (Short Circuit, Use Type Indices) (#…
f9426df 
…3101)

This PR skips the type checking logic for homogeneous graphs, resulting in a significant performance improvement.
It also uses the existing sampling API to return types using "indices" instead of edge ids for another major performance gain.

- [x] Tests
- [x] Type annotations

Closes #3099 
Closes #3100 
Closes #3080 
Partially addresses #3079

Authors:
  - Alex Barghi (https://github.com/alexbarghi-nv)
  - Erik Welch (https://github.com/eriknw)
  - Rick Ratzel (https://github.com/rlratzel)
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Vibhu Jawa (https://github.com/VibhuJawa)
  - Rick Ratzel (https://github.com/rlratzel)

URL: #3101
rapids-bot bot pushed a commit that referenced this issue Jan 27, 2023
@alexbarghi-nv
Replace PropertyGraph in cugraph-PyG with FeatureStore (#3159)
6e9b518 
Replaces PropertyGraph in cugraph-PyG with the new FeatureStore, which is the preferred solution for storing tensor features.
Closes #3151 
Closes #3079

Authors:
  - Alex Barghi (https://github.com/alexbarghi-nv)
  - Rick Ratzel (https://github.com/rlratzel)
  - Chuck Hastings (https://github.com/ChuckHastings)
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Vibhu Jawa (https://github.com/VibhuJawa)

Approvers:
  - Vibhu Jawa (https://github.com/VibhuJawa)
  - Rick Ratzel (https://github.com/rlratzel)

URL: #3159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexbarghi-nv alexbarghi-nv

Labels
feature request New feature or request
Projects
None yet
Milestone
23.02
Development

Successfully merging a pull request may close this issue.

Replace PropertyGraph in cugraph-PyG with FeatureStore alexbarghi-nv/cugraph
1 participant
@alexbarghi-nv