Fixes bug in NumberMap preventing use of string vertex IDs for MG graphs
#2688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…using it to use the incoming data type instead of the mapped type, which matters more when strings are passed in since they must be mapped to ints. Added new MG test that uses string vertex IDs. Cleaned up and fixed bugs in various MG test files that prevented pytest from discovering and running all tests in the "mg" test directory.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-22.10 #2688 +/- ##
===============================================
Coverage ? 60.10%
===============================================
Files ? 112
Lines ? 6151
Branches ? 0
===============================================
Hits ? 3697
Misses ? 2454
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…() instead of a tempfile and `read_csv()`.
|
LGTM - would like to see single GPU dask testing |
BradReesWork
approved these changes
Sep 22, 2022
Good idea, I filed #2714 for that. |
ChuckHastings
approved these changes
Sep 22, 2022
jnke2016
approved these changes
Sep 22, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2686
Summary
pagerankusing both SG and MG versions and ensures the results are identical. This new test was based on the code provided in issue How to read the graph edge if the node value is non-numerical #2686pytestfrom collecting tests when the entiremgsuite was specified. This probably would have been uncovered sooner if the MNMG nightly tests were configured to run differently (they run individual test files instead of havingpytestcollect all tests from themgdirectory).