Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo disabling MG C++ testing outputs for non-root processes #1615

Merged

Conversation

seunghwak
Copy link
Contributor

Disabling MG C++ testing outputs for non-root processes has an undesirable side effect of disabling error messages (e.g. exception outputs) as well. This makes failure diagnosis difficult in large-scale runs.

Delete the code disabling MG C++ testing outputs for non-root processes in this PR. In long run, we need a more elegant mechanism to disable only redundant test progress messages while still allowing error messages to be displayed.

@seunghwak seunghwak requested a review from a team as a code owner May 24, 2021 17:39
@seunghwak seunghwak added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 24, 2021
@seunghwak
Copy link
Contributor Author

Submitted #1616 for a longer term solution to disable only redundant test progress messages.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.06@570d811). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head b4f3319 differs from pull request most recent head 17cc7a0. Consider uploading reports for the commit 17cc7a0 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.06    #1615   +/-   ##
===============================================
  Coverage                ?   59.10%           
===============================================
  Files                   ?       79           
  Lines                   ?     3482           
  Branches                ?        0           
===============================================
  Hits                    ?     2058           
  Misses                  ?     1424           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 570d811...17cc7a0. Read the comment docs.

@BradReesWork BradReesWork added this to the 21.06 milestone May 25, 2021
@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 54eaabe into rapidsai:branch-21.06 May 25, 2021
@seunghwak seunghwak deleted the enh_enable_gtest_non_root_outputs branch June 24, 2021 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants