Skip to content

Commit

Permalink
Undo disabling MG C++ testing outputs for non-root processes (#1615)
Browse files Browse the repository at this point in the history
Disabling MG C++ testing outputs for non-root processes has an undesirable side effect of disabling error messages (e.g. exception outputs) as well. This makes failure diagnosis difficult in large-scale runs.

Delete the code disabling MG C++ testing outputs for non-root processes in this PR. In long run, we need a more elegant mechanism to disable only redundant test progress messages while still allowing error messages to be displayed.

Authors:
  - Seunghwa Kang (https://github.com/seunghwak)

Approvers:
  - Chuck Hastings (https://github.com/ChuckHastings)

URL: #1615
  • Loading branch information
seunghwak authored May 25, 2021
1 parent e541104 commit 54eaabe
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions cpp/tests/utilities/base_fixture.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -160,11 +160,6 @@ inline auto parse_test_options(int argc, char **argv)
auto const cmd_opts = parse_test_options(argc, argv); \
auto const rmm_mode = cmd_opts["rmm_mode"].as<std::string>(); \
auto resource = cugraph::test::create_memory_resource(rmm_mode); \
\
if (comm_rank != 0) { \
auto &listeners = ::testing::UnitTest::GetInstance()->listeners(); \
delete listeners.Release(listeners.default_result_printer()); \
} \
rmm::mr::set_current_device_resource(resource.get()); \
auto ret = RUN_ALL_TESTS(); \
MPI_TRY(MPI_Finalize()); \
Expand Down

0 comments on commit 54eaabe

Please sign in to comment.